Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOREF] Discussions translation fixes #2888

Conversation

aterstriep
Copy link
Contributor

NOREF

Description

  • Added the discussions translation file to src/i18n/en-US/index.ts
  • Updated translations to use count variable name and use singular/plural language (ex: 1 reply vs 2 replies)
  • Fixed typos

How to test this change

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@aterstriep aterstriep requested a review from a team as a code owner November 14, 2024 17:12
@aterstriep aterstriep requested review from adamodd and removed request for a team November 14, 2024 17:12
@aterstriep aterstriep changed the base branch from main to feature/EASI-4614_grb_discussions November 14, 2024 17:13
@aterstriep aterstriep merged commit 92c3f05 into feature/EASI-4614_grb_discussions Nov 14, 2024
12 checks passed
@aterstriep aterstriep deleted the NOREF/discussions-translation-fixes branch November 14, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants