Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4635] Discussions store methods and resolvers #2896

Merged

Conversation

mynar7
Copy link
Contributor

@mynar7 mynar7 commented Nov 20, 2024

EASI-4635

Description

This PR implements the discussions API store methods and connects them to the GQL resolvers so that adding/retrieving discussions is functional instead of just using mock data.

How to test this change

  • The Postman collection has endpoints created to create and reply to discussions.
  • There are no automated tests yet.

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@mynar7 mynar7 requested review from a team as code owners November 20, 2024 14:02
@mynar7 mynar7 requested review from samoddball and aterstriep and removed request for a team November 20, 2024 14:02
@mynar7 mynar7 requested a review from ClayBenson94 November 20, 2024 14:02
@mynar7 mynar7 requested a review from a team as a code owner November 20, 2024 14:12
@mynar7 mynar7 requested review from adamodd and removed request for a team November 20, 2024 14:12
…dd discussions seed data, and update postman collection to return more information on GRB Discussion Posts/Replies
Copy link
Contributor

@samoddball samoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks really good, left a comment

@mynar7 mynar7 merged commit 95efd7c into feature/EASI-4614_grb_discussions Nov 21, 2024
12 checks passed
@mynar7 mynar7 deleted the EASI-4635/discussions-store-methods branch November 21, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants