Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow numbered /bullet lists #2900

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

samoddball
Copy link
Contributor

@samoddball samoddball commented Nov 21, 2024

NOREF

Description

  • prevent bulleted and numbered lists

How to test this change

  • in tiptap editor for discussions, type - and hit space. a bulleted list should not appear
  • type 1. and hit space. a numbered list should not appear

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@samoddball samoddball requested a review from adamodd November 21, 2024 23:37
@samoddball samoddball marked this pull request as ready for review November 21, 2024 23:39
@samoddball samoddball requested a review from a team as a code owner November 21, 2024 23:39
@samoddball samoddball requested review from aterstriep and removed request for a team November 21, 2024 23:39
@adamodd
Copy link
Contributor

adamodd commented Nov 21, 2024

I'm not focused on this atm but in checking https://tiptap.dev/docs/editor/getting-started/configure#configure-extensions
it seems like the best way to narrow down to our few allowed markup tags is to set the extensions for I'm guessing Document, Paragraph, Text, instead of using StarterKit.

@ClayBenson94
Copy link
Collaborator

I'm not focused on this atm but in checking https://tiptap.dev/docs/editor/getting-started/configure#configure-extensions
it seems like the best way to narrow down to our few allowed markup tags is to set the extensions for I'm guessing Document, Paragraph, Text, instead of using StarterKit.

Agree! Sorry, I left my comments on the PR without seeing your comment @adamodd -- I didn't even catch Document, but I think we're both suggesting the same thing!

@samoddball
Copy link
Contributor Author

@ClayBenson94 @adamodd

this is what is now looks like

 extensions: [
        Document,
        Paragraph,
        Text,
        ...

Copy link
Contributor

@adamodd adamodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@samoddball samoddball merged commit 316650f into feature/EASI-4614_grb_discussions Nov 25, 2024
12 checks passed
@samoddball samoddball deleted the NOREF/disallow_lists branch November 25, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants