-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EASI-4671: Refactor configuration to build frontend for k8s as static content #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the frontend. It will now default to window.location.host in most circumstances
…eployment configurations to reflect changes in image paths and ports.
Jdwoodson
requested review from
aterstriep and
samoddball
and removed request for
a team
December 4, 2024 21:05
Jdwoodson
changed the title
EASI-4671:
EASI-4671: Refactor configuration to build frontend for k8s as static content
Dec 4, 2024
mynar7
reviewed
Dec 5, 2024
ClayBenson94
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EASI-4671
Description
This pull request includes changes to the deployment and configuration of the EASI application in EKS, focusing on environment variable management, Dockerfile updates, and Kubernetes configuration adjustments.
Environment Variable Management:
.github/workflows/deploy_to_eks.yml
to avoid hard-coding sensitive data.Dockerfile.frontend_k8s
to accept environment variables as build arguments and set them as environment variables within the container.Dockerfile Updates:
Dockerfile.backend_k8s
file, utilizing the same Dockerfile for the backend as is deployed via ECS.Kubernetes Configuration Adjustments:
easi-frontend-configmap.yaml
file and references to it in deployment configurations, moving environment variable management to build-time arguments. [1] [2] [3] [4] [5]Code Updates:
getWindowAddress
to retrieve the current browser's address.These changes collectively enhance the application's deployment flexibility, security, and maintainability.
How to test this change
Deploy to EKS
action and select the EASI-4671 branch.PR Author Checklist
PR Reviewer Guidelines