Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4723] Requester Task List Updates #3025

Merged
merged 21 commits into from
Feb 27, 2025

Conversation

garyjzhao
Copy link
Collaborator

@garyjzhao garyjzhao commented Feb 26, 2025

EASI-4723

Description

  • update GovTaskGrbMeeing test
  • add grbReviewType, grbReviewStartedAt, grbReviewAsyncRecordingTime, grbReviewAsyncEndDate, grbReviewStandardGRBMeetingTime, grbReviewAsyncGRBMeetingTime to the query
  • update copy
  • update mocks to account for new values needed

How to test this change

  • Navigate to the IT Goverance page and find step 6
  • Manipulate variables like review type and grbMeetingStatus to see the different variations
  • check to see variations match figma

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@garyjzhao garyjzhao requested a review from a team as a code owner February 26, 2025 15:58
@garyjzhao garyjzhao requested review from patrickseguraoddball and removed request for a team February 26, 2025 15:58
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scheduled date on the task list should use grbDate, not grbReviewStandardGRBMeetingTime

@garyjzhao garyjzhao force-pushed the EASI-4723/requester-task-list-updates branch from da1d150 to f709c21 Compare February 26, 2025 18:12
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG thanks!

@garyjzhao garyjzhao merged commit 9c62b26 into feature/async_grb_v2 Feb 27, 2025
13 checks passed
@garyjzhao garyjzhao deleted the EASI-4723/requester-task-list-updates branch February 27, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants