Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NOREF] Email Validation Error Message && Use Built-in React USWDS Required Marker in Form Labels #1549

Merged
merged 4 commits into from
Dec 4, 2024
Merged

[NOREF] Email Validation Error Message && Use Built-in React USWDS Required Marker in Form Labels #1549

merged 4 commits into from
Dec 4, 2024

Conversation

garyjzhao
Copy link
Contributor

NOREF

Description

Addressing https://cmsgov.slack.com/archives/C01B9TEC65A/p1733169342753359?thread_ts=1733163413.249109&cid=C01B9TEC65A

  • use built-in react USWDS required marker in form labels

How to test this change

  1. Navigate to the custom solution modals
  2. Put a invalid email address and check to see error message pops up
  3. Enter a valid email and check to see that the error message goes away

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@garyjzhao garyjzhao requested a review from a team as a code owner December 3, 2024 16:57
@garyjzhao garyjzhao requested review from patrickseguraoddball and removed request for a team December 3, 2024 16:57
@ClayBenson94
Copy link
Collaborator

@garyjzhao Changes look good, but I think snapshots might need to get updated!
https://github.com/CMS-Enterprise/mint-app/actions/runs/12144471382/job/33863890839?pr=1549

@garyjzhao
Copy link
Contributor Author

@ClayBenson94 pushed up snapshots in the lastest commit

patrickseguraoddball
patrickseguraoddball approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@garyjzhao garyjzhao merged commit 5c7ea1d into feature/MINT-3175_mto Dec 4, 2024
10 checks passed
@garyjzhao garyjzhao deleted the NOREF/email-validation-error-message branch December 4, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickseguraoddball patrickseguraoddball patrickseguraoddball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garyjzhao @ClayBenson94 @patrickseguraoddball