split logging to its own function

CMSgov · Jun 18, 2024 · 4e8b44a · 4e8b44a
1 parent a7b063e
commit 4e8b44a
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 14 deletions.
diff --git a/optout/src/main/java/gov/cms/ab2d/optout/OptOutHandler.java b/optout/src/main/java/gov/cms/ab2d/optout/OptOutHandler.java
@@ -32,21 +32,25 @@ public void processSQSMessage(SQSEvent.SQSMessage msg, Context context) {
 
             var optOutProcessing = processorInit(logger);
             var optOutResults = optOutProcessing.process(getFileName(notification), getBucketName(notification), ENDPOINT);
-            if (optOutResults != null) {
-                logger.log("OptOut Lambda completed. Total records processed today is: totaltoday=" + optOutResults.getTotalToday()
-                    + " Number of opt in today is: todayin=" + optOutResults.getOptInToday()
-                    + " Number of opt out today is: todayout=" + optOutResults.getOptOutToday()
-                    + " Total records processed to date is: totaltodate=" + optOutResults.getTotalAllTime()
-                    + " Total number of opt in is: totalin=" + optOutResults.getOptInTotal()
-                    + " Total number of opt out is: totalout=" + optOutResults.getOptOutTotal()
-                );
-            }
+            logResults(optOutResults, logger);
         } catch (Exception ex) {
             logger.log("An error occurred");
             throw new OptOutException("An error occurred", ex);
         }
     }
 
+    public void logResults(OptOutResults optOutResults, LambdaLogger logger) {
+        if (optOutResults != null) {
+            logger.log("OptOut Lambda completed. Total records processed today is: totaltoday=" + optOutResults.getTotalToday()
+                + " Number of opt in today is: todayin=" + optOutResults.getOptInToday()
+                + " Number of opt out today is: todayout=" + optOutResults.getOptOutToday()
+                + " Total records processed to date is: totaltodate=" + optOutResults.getTotalAllTime()
+                + " Total number of opt in is: totalin=" + optOutResults.getOptInTotal()
+                + " Total number of opt out is: totalout=" + optOutResults.getOptOutTotal()
+            );
+        }
+    }
+
     public OptOutProcessor processorInit(LambdaLogger logger) {
         return new OptOutProcessor(logger);
     }

diff --git a/optout/src/test/java/gov/cms/ab2d/optout/OptOutHandlerTest.java b/optout/src/test/java/gov/cms/ab2d/optout/OptOutHandlerTest.java
@@ -66,17 +66,29 @@ void optOutHandlerInvoke() {
         verify(logger, times(1)).log(anyString());
     }
 
+    @Test
+    void itLogsResults() {
+        LambdaLogger logger = mock(LambdaLogger.class);
+        OptOutResults optOutResults = new OptOutResults(1, 1, 2, 2);
+
+        String loggedMessage = "OptOut Lambda completed. Total records processed today is: totaltoday=" + optOutResults.getTotalToday()
+                + " Number of opt in today is: todayin=" + optOutResults.getOptInToday()
+                + " Number of opt out today is: todayout=" + optOutResults.getOptOutToday()
+                + " Total records processed to date is: totaltodate=" + optOutResults.getTotalAllTime()
+                + " Total number of opt in is: totalin=" + optOutResults.getOptInTotal()
+                + " Total number of opt out is: totalout=" + optOutResults.getOptOutTotal();
+
+        handler.logResults(optOutResults, logger);
+        verify(logger, times(1)).log(loggedMessage);
+    }
+
     @Test
     void itDoesNotLogWhenResultsAreNull() throws URISyntaxException {
         Context context = mock(Context.class);
         LambdaLogger logger = mock(LambdaLogger.class);
-        OptOutProcessor processor = mock(OptOutProcessor.class);
 
         when(context.getLogger()).thenReturn(logger);
-        when(handler.processorInit(any())).thenReturn(processor);
-        when(processor.process(anyString(), anyString(), anyString())).thenReturn(null);
-
-        handler.handleRequest(sqsEvent, context);
+        handler.logResults(null, logger);
         verify(logger, times(0)).log(anyString());
     }