Ab2d-6412/sonarqube fix 2 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # optout/src/test/java/gov/cms/ab2d/optout/OptOutHandlerTest.java
…ix-2 # Conflicts: # lambda-lib/src/main/java/gov/cms/ab2d/lambdalibs/lib/ParameterStoreUtil.java # optout/src/main/java/gov/cms/ab2d/optout/OptOutParameterStore.java
|
Looks like there's a failing test: here |
ildesenesence
approved these changes
Nov 15, 2024
The workflow always fails for AttributionDataShare lambda. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-6412
🛠 Changes
Moved duplicate code from OptOut and Attribution Lambdas to common class
ℹ️ Context
Fix for Sonarqube
🧪 Validation
Deployed and tested on IMPL:
2024-11-15T21:34:44.880Z
OptOut Lambda completed. Total records processed today is: totaltoday=7 Number of opt in today is: todayin=3 Number of opt out today is: todayout=4 Total records processed to date is: totaltodate=14 Total number of opt in is: totalin=8 Total number of opt out is: totalout=6
2024-11-15T13:00:46.888Z
File with name: bfdeft01/ab2d/out/T#EFT.ON.AB2D.NGD.REQ.D241115.T1300044 was uploaded to bucket: bfd-test-eft