Draft: CCLF lambda changes #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should create a new epic branch based off of main (eg ~ |
austincanada
changed the base branch from
main
to
epic/attribution-lambda-generalization
carlpartridge
approved these changes
Nov 8, 2024
carlpartridge
merged commit a3e0fcf
into
epic/attribution-lambda-generalization
6 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8405
🛠 Changes
Added the main entry to the CCLF lambda.
Added the logic flow for checking if the SQS event contains a CSV file path, or CCLF.
Renamed CCLF lambda functions to attribution agnostic.
Added parser functions for checking CSV file.
Added testing for CSV parser functions.
ℹ️ Context
These changes will be the entry for the lambda changes in order to make the CCLF lambda more agonistic to an attribution lambda.
🧪 Validation
This PR is a part of a larger group of PR's that will come later. Some of these entries don't function properly, such as the CSVImporter. Therefore this PR is more-or less a check for making sure the functionality is up to standards for the team.