-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BCDA-8548: Update Attribution Integration Test #1015
Merged
laurenkrugen-navapbc
merged 17 commits into
epic/attribution-lambda-generalization
from
lauren/BCDA-8548
Dec 12, 2024
Merged
BCDA-8548: Update Attribution Integration Test #1015
laurenkrugen-navapbc
merged 17 commits into
epic/attribution-lambda-generalization
from
lauren/BCDA-8548
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenkrugen-navapbc
temporarily deployed
to
test
December 6, 2024 17:31 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
changed the base branch from
main
to
epic/attribution-lambda-generalization
December 6, 2024 17:31
laurenkrugen-navapbc
temporarily deployed
to
test
December 6, 2024 17:58 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 6, 2024 18:07 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 6, 2024 18:15 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 6, 2024 18:24 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 6, 2024 18:31 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 6, 2024 18:42 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 6, 2024 18:50 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 10, 2024 15:58 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 10, 2024 16:11 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 10, 2024 18:37 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 11, 2024 18:15 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 11, 2024 18:31 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 11, 2024 18:59 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 11, 2024 20:05 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 11, 2024 20:46 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
temporarily deployed
to
test
December 11, 2024 21:16 — with
GitHub Actions
Inactive
carlpartridge
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Looks like there are some failing tests 😢 |
laurenkrugen-navapbc
temporarily deployed
to
test
December 12, 2024 18:36 — with
GitHub Actions
Inactive
laurenkrugen-navapbc
merged commit Dec 12, 2024
ca706c1
into
epic/attribution-lambda-generalization
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8548
🛠 Changes
ℹ️ Context
Made to support csv attribution types for models that utilize csv attribution files.
🧪 Validation
Integration test github action has been updated to include steps to generate a csv attribution file and ingest it. Test is passing and manually validated that database entries looks OK.