Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCDA-8548: Update Attribution Integration Test #1015

Merged

Conversation

laurenkrugen-navapbc
Copy link
Contributor

@laurenkrugen-navapbc laurenkrugen-navapbc commented Dec 6, 2024

🎫 Ticket

https://jira.cms.gov/browse/BCDA-8548

🛠 Changes

  • github workflow for attribution integration test has been updated to include the csv file type

ℹ️ Context

Made to support csv attribution types for models that utilize csv attribution files.

🧪 Validation

Integration test github action has been updated to include steps to generate a csv attribution file and ingest it. Test is passing and manually validated that database entries looks OK.

@laurenkrugen-navapbc laurenkrugen-navapbc changed the base branch from main to epic/attribution-lambda-generalization December 6, 2024 17:31
bcda/cclf/parser.go Outdated Show resolved Hide resolved
bcda/cclf/parser.go Outdated Show resolved Hide resolved
bcda/cclf/parser_test.go Show resolved Hide resolved
Copy link
Collaborator

@carlpartridge carlpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@carlpartridge
Copy link
Collaborator

Looks like there are some failing tests 😢

@laurenkrugen-navapbc laurenkrugen-navapbc merged commit ca706c1 into epic/attribution-lambda-generalization Dec 12, 2024
8 checks passed
@laurenkrugen-navapbc laurenkrugen-navapbc deleted the lauren/BCDA-8548 branch December 12, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants