Skip to content

BFD-3101: Add deprecated flag to _search endpoints for GET method in OpenAPI spec #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 30, 2024

Conversation

dondevun
Copy link
Contributor

@dondevun dondevun commented Oct 18, 2024

JIRA Ticket:
BFD-3101

What Does This PR Do?

Updates the OpenAPI spec to deprecated get _search endpoints.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

Generated the doc locally, verified correctness.

@dondevun dondevun changed the title Bfd 3101 BFD-3101: Add deprecated flag to _search endpoints for GET method Oct 21, 2024
@dondevun dondevun changed the title BFD-3101: Add deprecated flag to _search endpoints for GET method BFD-3101: Add deprecated flag to _search endpoints for GET method in OpenAPI spec Oct 21, 2024
MahiFentaye
MahiFentaye previously approved these changes Oct 22, 2024
@dondevun dondevun requested a review from mjburling October 24, 2024 12:14
Copy link
Member

@mjburling mjburling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran an OOB release of this branch, BFD-3101 and likewise, ran a Static Site deployment–changes look exactly as we'd expect. Thanks!

@mjburling mjburling enabled auto-merge (squash) October 30, 2024 18:01
@mjburling mjburling merged commit 5eff973 into master Oct 30, 2024
6 checks passed
@mjburling mjburling deleted the BFD-3101 branch October 30, 2024 18:11
dondevun added a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants