Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BB2-1946] Update border color (when clicked) on buttons of site static from red to blue-grey #62

Merged

Conversation

JFU-GIT
Copy link
Contributor

@JFU-GIT JFU-GIT commented Jan 27, 2023

JIRA Ticket:
BB2-1946

User Story or Bug Summary:

The border color of the large buttons in the blue hero banner on the Blue Button static site change to red when clicked. (see attached screenshot)
Context:

Looking at the design system, I think the on-click state should be like the “Solid” variation example “Button variations on dark background” from the core design system page re: buttons

Acceptance Criteria

  1. confirm the button on-click display matches the design system specifications

What Does This PR Do?

What Should Reviewers Watch For?

Verify that with the css generated from bluebutton-css repo, the site static buttons that used to have RED border (outline-color) when clicked, now has blue-grey color outline when clicked (this make the cosmetic characteristic more smooth - red usually indicates warning, dangerous etc.)

Note, here we only update the RED outline-color for the buttons, other links e.g. the links such as the links in the footer of the pages will still show purple-ish color when clicked, that is actually needed (you can check out CMS, VA sites for similar styling)

If you're reviewing this PR, please check these things, in particular:

  • TODO

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

  • If the answer to any of the questions below is Yes, then here's a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence: N/A.
    • Does this PR add any new software dependencies? No.
    • Does this PR modify or invalidate any of our security controls? No.
    • Does this PR store or transmit data that was not stored or transmitted before? No.
  • If the answer to any of the questions below is Yes, then please add @StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.
    • Do you think this PR requires additional review of its security implications for other reasons? No.

What Needs to Be Merged and Deployed Before this PR?

This PR cannot be either merged or deployed until the following pre-requisite changes have been fully deployed:

  • CMSgov/some_repo#42

Submitter Checklist

I have gone through and verified that...:

  • This PR is reasonably limited in scope, to help ensure that:
    1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
    2. There isn't too much of a burden on reviewers.
    3. Any problems it causes have a small "blast radius".
    4. It'll be easier to rollback if that becomes necessary.
  • I have named this PR and its branch such that they'll be automatically be linked to the (most) relevant Jira issue, per: https://confluence.atlassian.com/adminjiracloud/integrating-with-development-tools-776636216.html.
  • This PR includes any required documentation changes, including README updates and changelog / release notes entries.
  • All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
  • All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
  • Reviews are requested from both:
    • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
    • Any relevant engineers on other projects (e.g. BFD, SLS, etc.).
  • Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
    • Please review the standards every few months to ensure you're familiar with them.

@JFU-GIT JFU-GIT changed the title [BB2-1946] Update border color (when clicked) on buttons of site static from red to grey [BB2-1946] Update border color (when clicked) on buttons of site static from red to blue-grey Jan 27, 2023
@JFU-GIT JFU-GIT requested review from dtisza1 and ajshred January 27, 2023 19:03
Copy link
Contributor

@ajshred ajshred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good James!

Copy link
Contributor

@dtisza1 dtisza1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JFU-GIT This looks good to me!

@JFU-GIT JFU-GIT merged commit c4e7a1a into master Feb 1, 2023
@JFU-GIT JFU-GIT deleted the jfuqian/BB2-1946-update-border-color-on-buttons-links-PR branch February 1, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants