Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #73

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

jimmyfagan
Copy link
Contributor

JIRA Ticket:
BB2-3303

What Does This PR Do?

I updated the PR template in this repo for consistency with what we will use moving forward in other repos.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

Validation

I used the new template for this PR.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team security engineer's approval.

Copy link

@noor1027 noor1027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmyfagan jimmyfagan merged commit 9da77fa into master Aug 13, 2024
@jimmyfagan jimmyfagan deleted the jimmyfagan/bb2-3303-update-pr-template branch August 13, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants