-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB2-3224: Establish C4DIC feature branch #1205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Played with Postman + Local setup, got C4DIC resources as expected.
Great work on demo a multi profile support API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimmyfagan just a note this general PR looks good, However I did notice some failures in the CI on Jenkins from Flake8 for formatting. We might need to add some of these files to the exclusion list
Good call @sb-benohe I didn't have pre-commit installed on the repo, that's a good topic to bring back to the team probably to address that topic from retro. Pushed fixes, will check CI and then likely merge what I have into the longer-term feature branch. |
JIRA Ticket:
BB2-3224
User Story or Bug Summary:
This PR establishes a feature branch that can be used for POCs, demos, sample app implementation, using C4DIC compliant fhir resources.
What Does This PR Do?
This PR builds off of Adrian's C4DIC POC but with some adjustments based on our current plans moving forward for C4DIC with BFD.
What Should Reviewers Watch For?
If you're reviewing this PR, please test by importing the new Postman collection from this page (look for
Blue Button Local Environment (C4DIC)
) to verify that the sample C4DIC resources can be retrieved. You will need to generate a new access token that contains the Organization scope to be able to use the Organization endpoint.Also, note that this is a feature branch which will not be deployed to any real environments in this state. This would be re-reviewed before ever being merged to the master branch.
What Security Implications Does This PR Have?
Submitters should complete the following questionnaire:
What Needs to Be Merged and Deployed Before this PR?
N/A
Any Migrations?
None
Submitter Checklist
I have gone through and verified that...:
README
updates and changelog / release notes entries.TODO
and/orFIXME
comments, which include a JIRA ticket ID for any items that require urgent attention.