Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-3224: Establish C4DIC feature branch #1205

Merged
merged 8 commits into from
Jun 13, 2024
Merged

Conversation

jimmyfagan
Copy link
Contributor

@jimmyfagan jimmyfagan commented Jun 7, 2024

JIRA Ticket:
BB2-3224

User Story or Bug Summary:
This PR establishes a feature branch that can be used for POCs, demos, sample app implementation, using C4DIC compliant fhir resources.

What Does This PR Do?

This PR builds off of Adrian's C4DIC POC but with some adjustments based on our current plans moving forward for C4DIC with BFD.

What Should Reviewers Watch For?

If you're reviewing this PR, please test by importing the new Postman collection from this page (look for Blue Button Local Environment (C4DIC)) to verify that the sample C4DIC resources can be retrieved. You will need to generate a new access token that contains the Organization scope to be able to use the Organization endpoint.

Also, note that this is a feature branch which will not be deployed to any real environments in this state. This would be re-reviewed before ever being merged to the master branch.

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

  • If the answer to any of the questions below is Yes, then here's a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence: N/A.
    • Does this PR add any new software dependencies? Yes or No.
    • Does this PR modify or invalidate any of our security controls? Yes or No.
    • Does this PR store or transmit data that was not stored or transmitted before? Yes or No.
  • If the answer to any of the questions below is Yes, then please add a Security Engineer and ISSO as a reviewer, and note that this PR should not be merged unless/until he also approves it.
    • Do you think this PR requires additional review of its security implications for other reasons? Yes or No.

What Needs to Be Merged and Deployed Before this PR?

N/A

Any Migrations?

None

Submitter Checklist

I have gone through and verified that...:

  • This PR is reasonably limited in scope, to help ensure that:
    1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
    2. There isn't too much of a burden on reviewers.
    3. Any problems it causes have a small "blast radius".
    4. It'll be easier to rollback if that becomes necessary.
  • I have named this PR and its branch such that they'll be automatically be linked to the (most) relevant Jira issue, per: https://confluence.atlassian.com/adminjiracloud/integrating-with-development-tools-776636216.html.
  • This PR includes any required documentation changes, including README updates and changelog / release notes entries.
  • All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
  • All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
  • Reviews are requested from both:
    • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
    • Any relevant engineers on other projects (e.g. BFD, SLS, etc.).
  • Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
    • Please review the standards every few months to ensure you're familiar with them.

@jimmyfagan jimmyfagan changed the title Feature/c4dic poc BB2-3224: Establish C4DIC feature branch Jun 10, 2024
@jimmyfagan jimmyfagan marked this pull request as ready for review June 10, 2024 16:39
@JFU-NAVA-PBC JFU-NAVA-PBC self-requested a review June 11, 2024 16:57
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Played with Postman + Local setup, got C4DIC resources as expected.
Great work on demo a multi profile support API

Copy link
Contributor

@sb-benohe sb-benohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimmyfagan just a note this general PR looks good, However I did notice some failures in the CI on Jenkins from Flake8 for formatting. We might need to add some of these files to the exclusion list

@jimmyfagan
Copy link
Contributor Author

Good call @sb-benohe I didn't have pre-commit installed on the repo, that's a good topic to bring back to the team probably to address that topic from retro. Pushed fixes, will check CI and then likely merge what I have into the longer-term feature branch.

@jimmyfagan jimmyfagan merged commit 205542a into feature/c4dic Jun 13, 2024
4 checks passed
@jimmyfagan jimmyfagan deleted the feature/c4dic-poc branch June 13, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants