-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BB2-3290: Connect to BFD test environment for C4DIC #1222
Conversation
DJANGO_USER_ID_SALT=${DJANGO_USER_ID_SALT} | ||
DJANGO_USER_ID_ITERATIONS=${DJANGO_USER_ID_ITERATIONS} | ||
FHIR_URL="https://prod-sbx.bfd.cms.gov" | ||
FHIR_URL="https://test.bfd.cms.gov" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an intentional change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine it must be. It just seemed like the kind of things I may accidentally commit after making local testing changes, lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea sorry probably not enough context in the description. C4DIC is only enabled in BFD's test env, so this change is meant to point over to that.
@@ -56,7 +56,7 @@ def __init__(self, version=1): | |||
self.resource_type = "Patient" | |||
|
|||
def get(self, request, *args, **kwargs): | |||
return_c4dic = True | |||
return_c4dic = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As is, this seems to always be false. Are we just enforcing this can't work at all for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to leave this logic in there in case we wanted to hard code resources again, it would just be flipping these to true for whichever calls you wanted hard coded resources for and then adjusting the contents of the corresponding json file. Just to allow us to test with different resource fields without necessarily waiting for BFD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. I think that's fine to have to switch these manually to test. No world where we'd want that to work for anyone else, lol. Too ephemeral for a feature flag, otherwise
JIRA Ticket:
BB2-3290
What Does This PR Do?
Updates the feature branch to be able to seamlessly connect to BFD's test environment to retrieve C4DIC resources.
What Should Reviewers Watch For?
Run locally and test API calls to retrieve resources from test.bfd.cms.gov. (Note that you might need to use Cisco AnyConnect instead of ZScaler to do this)
What Security Implications Does This PR Have?
Submitters should complete the following questionnaire:
What Needs to Be Merged and Deployed Before this PR?
N/A
Any Migrations?
Submitter Checklist
I have gone through and verified that...:
README
updates and changelog / release notes entries.TODO
and/orFIXME
comments, which include a JIRA ticket ID for any items that require urgent attention.