Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-3290: Connect to BFD test environment for C4DIC #1222

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

jimmyfagan
Copy link
Contributor

@jimmyfagan jimmyfagan commented Jul 15, 2024

JIRA Ticket:
BB2-3290

What Does This PR Do?

Updates the feature branch to be able to seamlessly connect to BFD's test environment to retrieve C4DIC resources.

What Should Reviewers Watch For?

Run locally and test API calls to retrieve resources from test.bfd.cms.gov. (Note that you might need to use Cisco AnyConnect instead of ZScaler to do this)

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

  • If the answer to any of the questions below is Yes, then here's a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence: N/A.
    • Does this PR add any new software dependencies? Yes or No.
    • Does this PR modify or invalidate any of our security controls? Yes or No.
    • Does this PR store or transmit data that was not stored or transmitted before? Yes or No.
  • If the answer to any of the questions below is Yes, then please add a Security Engineer and ISSO as a reviewer, and note that this PR should not be merged unless/until he also approves it.
    • Do you think this PR requires additional review of its security implications for other reasons? Yes or No.

What Needs to Be Merged and Deployed Before this PR?

N/A

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime, etc)
  • No migrations

Submitter Checklist

I have gone through and verified that...:

  • This PR is reasonably limited in scope, to help ensure that:
    1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
    2. There isn't too much of a burden on reviewers.
    3. Any problems it causes have a small "blast radius".
    4. It'll be easier to rollback if that becomes necessary.
  • I have named this PR and its branch such that they'll be automatically be linked to the (most) relevant Jira issue, per: https://confluence.atlassian.com/adminjiracloud/integrating-with-development-tools-776636216.html.
  • This PR includes any required documentation changes, including README updates and changelog / release notes entries.
  • All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
  • All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
  • Reviews are requested from both:
    • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
    • Any relevant engineers on other projects (e.g. BFD, SLS, etc.).
  • Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
    • Please review the standards every few months to ensure you're familiar with them.

@jimmyfagan jimmyfagan changed the base branch from master to feature/c4dic July 16, 2024 21:32
@jimmyfagan jimmyfagan marked this pull request as ready for review July 16, 2024 21:58
@jimmyfagan jimmyfagan changed the title [WIP] Connect to BFD test environment for C4DIC BB2-3290: Connect to BFD test environment for C4DIC Jul 16, 2024
DJANGO_USER_ID_SALT=${DJANGO_USER_ID_SALT}
DJANGO_USER_ID_ITERATIONS=${DJANGO_USER_ID_ITERATIONS}
FHIR_URL="https://prod-sbx.bfd.cms.gov"
FHIR_URL="https://test.bfd.cms.gov"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an intentional change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine it must be. It just seemed like the kind of things I may accidentally commit after making local testing changes, lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea sorry probably not enough context in the description. C4DIC is only enabled in BFD's test env, so this change is meant to point over to that.

@@ -56,7 +56,7 @@ def __init__(self, version=1):
self.resource_type = "Patient"

def get(self, request, *args, **kwargs):
return_c4dic = True
return_c4dic = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is, this seems to always be false. Are we just enforcing this can't work at all for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to leave this logic in there in case we wanted to hard code resources again, it would just be flipping these to true for whichever calls you wanted hard coded resources for and then adjusting the contents of the corresponding json file. Just to allow us to test with different resource fields without necessarily waiting for BFD.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. I think that's fine to have to switch these manually to test. No world where we'd want that to work for anyone else, lol. Too ephemeral for a feature flag, otherwise

@jimmyfagan jimmyfagan merged commit d294cb4 into feature/c4dic Jul 17, 2024
6 checks passed
@jimmyfagan jimmyfagan deleted the feature/c4dic-bfd-integration branch July 17, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants