Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jimfuqian/BB2-3280-C4DIC POC: Enrich c4dic coverage w supporting image #1241

Merged
merged 5 commits into from
Sep 9, 2024
Merged

jimfuqian/BB2-3280-C4DIC POC: Enrich c4dic coverage w supporting image #1241

merged 5 commits into from
Sep 9, 2024

Conversation

JFU-NAVA-PBC
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC commented Sep 3, 2024 •
edited
Loading

JIRA Ticket:
BB2-3280

What Does This PR Do?

Enrich C4DIC Coverage with SupportingImage for POC purpose.

What Should Reviewers Watch For?

The supporting image provisioned can be viewed (rendered) by FE PR FE

If you're reviewing this PR, please check for these things in particular:

Validation

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@JFU-NAVA-PBC JFU-NAVA-PBC marked this pull request as draft September 3, 2024 14:55
@JFU-NAVA-PBC JFU-NAVA-PBC marked this pull request as ready for review September 3, 2024 21:40
jimmyfagan
jimmyfagan approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I know there may be more changes here given what we talked about to get the _profile to work, but feel free to deliver this and make adjustments in a separate PR or add to this PR and re-request review, whatever works best!

apps/fhir/bluebutton/views/search.py Outdated
"url": "image",
"valueAttachment": {
"contentType": "image/png",
"data": "<replace with base64 encoded iamge png here>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"data": "<replace with base64 encoded iamge png here>"
"data": "<replace with base64 encoded image png here>"

@JFU-NAVA-PBC JFU-NAVA-PBC merged commit 2aa4b40 into feature/c4dic Sep 9, 2024
4 checks passed
@JFU-NAVA-PBC JFU-NAVA-PBC deleted the jimfuqian/BB2-3280-C4DIC-POC-Coverage-c4dic-supportingImage-ext-by-enrichment branch September 9, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyfagan jimmyfagan jimmyfagan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JFU-NAVA-PBC @jimmyfagan