Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB2-3391: Rollback supporting image enhancement #1249

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

jimmyfagan
Copy link
Contributor

@jimmyfagan jimmyfagan commented Sep 24, 2024

JIRA Ticket:
BB2-3391

What Does This PR Do?

This PR rolls back the resource enhancement done in a previous PR, since the enhancement will no longer be needed. Additionally, a dependency that was introduced in that PR is being removed.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:
Any lingering dependencies or blocks of code I missed?

Validation

Validated this by running the server locally and retrieving C4DIC resources.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@jimmyfagan jimmyfagan marked this pull request as ready for review September 24, 2024 15:25
Copy link
Contributor

@JFU-NAVA-PBC JFU-NAVA-PBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimmyfagan jimmyfagan merged commit fa4e0af into feature/c4dic Sep 24, 2024
3 of 4 checks passed
@jimmyfagan jimmyfagan deleted the feature/c4dic-jimmy-bb2-3391 branch September 24, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants