-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLUEBUTTON-934 New User Self-Identification #730
Conversation
Here's one thing I might need help with: I want to change the way we are handling contextual messages. You'll see in the PR that I commented out the Is that a good course of action there? |
I just moved the email to be the third field on the signup form, and removed the help texts. |
I like the way those look on the login page! That idea sounds good to me. And possibly move that in to the "include/messages.html" template when ready for all of them to be presented that way. Here is a list of templates including that: |
The generic/bootstrapform.html template was being used by both signup and mfa views. I removed that template and split it in to two new templates under apps/accounts/templates/registration called signup.html and mfa.html. |
apps/accounts/forms.py
Outdated
"your chosen password to make " | ||
"sure it was entered correctly.")) | ||
label=_("Password (again)")) | ||
identification_choice = forms.ChoiceField(label="Your Role", choices=[]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be done directly. Possibly with a ModelChoiceField or a MultipleModelChoiceField with a different widget?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY! This is nicer. I changed it to use ModelChoiceField .
…s and removes whitespace
Note: Styles for this PR are dependent on pulling down this progress from the CSS repo:
CMSgov/bluebutton-css#27
There is some more cleanup and tweaks I probably want to do on my side, but I wanted to open this up for collaboration if that would be most productive. Not sure exactly how we want to proceed, but we can talk about it here.