Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLUEBUTTON-934 New User Self-Identification #730

Merged
merged 12 commits into from
Jun 4, 2019
Merged

BLUEBUTTON-934 New User Self-Identification #730

merged 12 commits into from
Jun 4, 2019

Conversation

johnfrenchxyz
Copy link
Contributor

@johnfrenchxyz johnfrenchxyz commented May 21, 2019

Note: Styles for this PR are dependent on pulling down this progress from the CSS repo:

CMSgov/bluebutton-css#27

There is some more cleanup and tweaks I probably want to do on my side, but I wanted to open this up for collaboration if that would be most productive. Not sure exactly how we want to proceed, but we can talk about it here.

@johnfrenchxyz
Copy link
Contributor Author

Here's one thing I might need help with:

I want to change the way we are handling contextual messages. You'll see in the PR that I commented out the div at the top where we used to include messages.html. I think what I might want to do is just put that if messages around the gradient-messages-container and put the message text inside like those sample messages on the login page.

Is that a good course of action there?

@johnfrenchxyz
Copy link
Contributor Author

Another thing I need help with:

On the signup form:

  • Can we move Frist name and Last Name to be first in the form?
  • Can we remove the messages under the inputs?
  • Can we add the select box to the actual generated form and create tag for the users?

signup-form

@johnfrenchxyz johnfrenchxyz requested review from dtisza1 and whytheplatypus and removed request for dtisza1 May 21, 2019 16:03
@dtisza1
Copy link
Contributor

dtisza1 commented May 24, 2019

I just moved the email to be the third field on the signup form, and removed the help texts.

@dtisza1
Copy link
Contributor

dtisza1 commented May 24, 2019

Here's one thing I might need help with:

I want to change the way we are handling contextual messages. You'll see in the PR that I commented out the div at the top where we used to include messages.html. I think what I might want to do is just put that if messages around the gradient-messages-container and put the message text inside like those sample messages on the login page.

Is that a good course of action there?

I like the way those look on the login page! That idea sounds good to me. And possibly move that in to the "include/messages.html" template when ready for all of them to be presented that way.

Here is a list of templates including that:
./apps/accounts/templates/account-settings.html
./apps/accounts/templates/registration/password_forgot_reset_confirm_form.html
./apps/accounts/templates/registration/password_forgot_form.html
./apps/accounts/templates/registration/password_forgot_reset_complete.html
./apps/accounts/templates/registration/passwd_change_form.html
./apps/accounts/templates/registration/password_forgot_reset_done.html
./apps/home/templates/authenticated-home.html
./apps/dot_ext/templates/endorsements/base.html
./apps/dot_ext/templates/oauth2_provider/base.html
./templates/generic/bootstrapform.html
./templates/generic/split60_50.html

@dtisza1 dtisza1 added the WIP Work in progress label May 24, 2019
@dtisza1
Copy link
Contributor

dtisza1 commented May 24, 2019

The generic/bootstrapform.html template was being used by both signup and mfa views. I removed that template and split it in to two new templates under apps/accounts/templates/registration called signup.html and mfa.html.

@dtisza1 dtisza1 removed the WIP Work in progress label May 31, 2019
"your chosen password to make "
"sure it was entered correctly."))
label=_("Password (again)"))
identification_choice = forms.ChoiceField(label="Your Role", choices=[])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be done directly. Possibly with a ModelChoiceField or a MultipleModelChoiceField with a different widget?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY! This is nicer. I changed it to use ModelChoiceField .

apps/accounts/forms.py Outdated Show resolved Hide resolved
@dtisza1 dtisza1 requested a review from whytheplatypus June 3, 2019 20:58
@dtisza1 dtisza1 merged commit 99725de into master Jun 4, 2019
@njdister njdister deleted the BLUEBUTTON-934 branch February 1, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants