Skip to content

[WNMGDS-2638] Publish the drawer manager feature #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

pwolfert
Copy link
Contributor

@pwolfert pwolfert commented Jan 22, 2024

Summary

WNMGDS-2638

Based on this recent RFC

Previously we held back on releasing our DrawerManager / useDrawerManager feature (see this old RFC) because of this focus-management bug. Now that the bug is fixed, we can roll this new feature out, and app teams will be able to offload some of their logic to the design system.

  • Started exporting DrawerManager and useDrawerManager from our design system packages
  • Updated all the documentation and made it visible
  • Changed the names of the return-value properties to be general about their usage context (not just for click-handling) but more specific about being for a drawer (so they don't get lost in a parent component's code)

How to test

Take a look at Storybook and the doc site

Checklist

  • Prefixed the PR title with the Jira ticket number as [WNMGDS-####] Title or [NO-TICKET] if this is unticketed work.
  • Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • Selected appropriate Impacts, multiple can be selected.
  • Selected appropriate release milestone

@pwolfert pwolfert added Impacts: Core Impacts the core DS primarily, changes may occur in other themes as well. Type: Added Indicates a new feature. labels Jan 22, 2024
@pwolfert pwolfert added this to the 9.0.0-beta.3 milestone Jan 22, 2024
@pwolfert pwolfert requested a review from zarahzachz January 22, 2024 23:30
@pwolfert pwolfert merged commit 4db9c28 into main Jan 23, 2024
@pwolfert pwolfert deleted the pwolfert/drawer-manager branch January 23, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts: Core Impacts the core DS primarily, changes may occur in other themes as well. Type: Added Indicates a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants