-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WNMGDS-2160] Consolidate docs theme #2922
[WNMGDS-2160] Consolidate docs theme #2922
Conversation
…nt bringing in entire hgov DS
this branch has the latest of all UI updates in it:
only reason I'm asking for a review in this branch instead of merging it into the info-architecture one is i'm not sure we want to keep the "persisting theme on docs site" work. open to discussing, but i personally found it hard to know what theme i was looking at when everything looked the same. it could be some sorta bias though since i've been working in this site for so long - i just don't think the core theme looks distinct enough from hgov to be our default docs look and it could confuse non-hgov users on our site |
One way that would provide a clue about what theme they're looking at that seems to be missing in this branch is the background color of the theme-switcher section changing to match the primary color for that theme |
Well the color thing was in the original designs, or I would have pushed back on the idea. I think we at least need the brand color somewhere. |
Oh yeah, I vote for the brand color on the theme swither itself! The header switch would also be good, but I could see it being a more missable difference. Otherwise, looks good! |
WNMGDS-2160
Demo url
I am seeing a bug with this demo link, but it's a bug that exists in PROD so it seems like it's out of scope for this PR (see video for bug)
Screen.Recording.2024-02-06.at.5.14.17.PM.mov
The best I can describe it, the site seems to "forget" its theme and defaults to Core until you navigate to other pages within the site.