[WNMGDS-2780] Implement stricter warnings when the isOpen prop isn't used
#3121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Require it in TypeScript - Up the dev warnings to throwing dev errors - Display a console error message in prod (previously silent in prod)
pwolfert
added
Impacts: Core
zarahzachz
approved these changes
Jun 11, 2024
|
Forgot to push my commit that fixes the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In the Release 9.0 blog post, we announced that we were changing the way applications open and close dialogs and help drawers. Here is a code migration guide. We added a console warning for the old behavior in development mode, but after seeing that teams are still using the old API and running into issues, we decided it's time to increase the visibility of this change.
Summary
https://jira.cms.gov/browse/WNMGDS-2780
Implement stricter warnings when the
isOpenprop isn't used (the new dialog API).How to test
You can try it out manually if you want. Unit tests are testing for the error-throwing.
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.