Docker, Makefile, and Script Updates #2324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecks -Updated Makefile with better targets -Updated test scripts to use make targets -Added some variables for flexibility in setting docker project -Replaced bash scripting with posix because of support variations in cicd -Replaced curl with wget in dpc-admin and dpc-web entrypoints because there is no curl in images
… pre-smoke mvn clean
NavaCharlesHorowitz
added
the
scripts
NavaCharlesHorowitz
force-pushed
the
ceh1/tech-debt-oct24-1
branch
from
6690040 to
36e8664
Compare
added 3 commits
November 30, 2024 21:29
|
This has been successfully run through Full Deploy and Release (to dev). |
|
I'm concerned about how much this is going to change my day to day dev workflow, and it's not quite obvious to me just how drastic a change it's going to be. I would like to request some documentation to be added to this pull request, possibly in a new section of the README. |
|
Good call -- I had some nice doc updates but lost them when I blew away the original branch and PR. I will update docs as the last commit to this PR asap after I get main merged in with no problems. |
… set for developer lifecycle. Some updates to main readme
Dropped FHIR back to 6.4.5 to prevent unit test failure
NavaCharlesHorowitz
force-pushed
the
ceh1/tech-debt-oct24-1
branch
from
ba33679 to
48e9810
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
This is one component of my catchall tech debt/housekeeping ticket:
https://jira.cms.gov/browse/DPC-4298
🛠 Changes
-Replaced dadarek containers with docker v3 dependencies and healthchecks
-Updated Makefile with better targets
-Updated test scripts to use make targets
-Added some variables for flexibility in setting docker project -Replaced bash scripting with posix because of support variations in cicd -Replaced curl with wget in dpc-admin and dpc-web entrypoints because there is no curl in images
ℹ️ Context
Simplify and streamline Docker and system lifecycle work, add flexibility through configurability, reduce warning clutter
🧪 Validation
Ran through system lifecycle, used Makefile targets, ran scripts.