-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Me/dpc 4324 hapi jpa eval #2339
Draft
MEspositoE14s
wants to merge
12
commits into
main
Choose a base branch
from
me/dpc-4323-hapi-jpa-eval
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker-compose.yml
Outdated
@@ -4,7 +4,7 @@ services: | |||
image: postgres:14 | |||
command: postgres -c 'max_connections=250' | |||
environment: | |||
- POSTGRES_MULTIPLE_DATABASES=dpc_attribution,dpc_queue,dpc_auth,dpc_consent,dpc-website_development,bcda,dpc-portal_development | |||
- POSTGRES_MULTIPLE_DATABASES=dpc_attribution,dpc_queue,dpc_auth,dpc_consent,dpc-website_development,bcda,dpc-portal_development,hapi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well remove dpc_attribution...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4324
Note:
This is strictly a proof of concept that will never be merged. It doesn't need to be reviewed fully, but if you choose to, don't let the large number of changes scare you off. The majority of them are deletes from removing dpc-attribution.
🛠 Changes
Completely removed dpc-attribution and replaced it with an off the shelf FHIR server.
ℹ️ Context
The ticket was to evaluate what FHIR services are currently available in the market and see if we could use them to improve our system. This PR shows the approximate level of effort required to completely remove dpc-attribution and replace it with an off the shelf FHIR server. This being a PoC, there are a number of caveats, though:
Benefits to this approach
Negatives
🧪 Validation
Run
make ci-app
locally and all of the tests should pass. You can also run the full api locally and fire queries at it with Postman.