Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switching from recursion to a loop. In theory, determining the column name can go to infinity #36

Merged
merged 2 commits into from
May 23, 2024

Conversation

shaselton-usds
Copy link
Collaborator

@shaselton-usds shaselton-usds commented May 21, 2024

One line description of your change (less than 72 characters)

Allows for any number of columns for the CSV wide template.

Problem

The previous update supported columns up to AAA (roughly 700 column), but then provides an undefined in the string that is being constructed afterwards.

Solution

Changed the recursive solution for one with a loop and builds out the string that way. Now the column size can grow to any length, though highly unlikely.

Test Plan

I added some simple test cases that demonstrate the problem and didn't previously exist for the function

Copy link
Member

@patsier-cms patsier-cms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! I initially wanted to get in a quick fix but it's a good call to get rid of the column limitation going forward

@shaselton-usds shaselton-usds merged commit 9ffecf9 into main May 23, 2024
4 checks passed
@shaselton-usds shaselton-usds deleted the expand-col-count branch May 23, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants