switching from recursion to a loop. In theory, determining the column name can go to infinity #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One line description of your change (less than 72 characters)
Allows for any number of columns for the CSV wide template.
Problem
The previous update supported columns up to AAA (roughly 700 column), but then provides an
undefined
in the string that is being constructed afterwards.Solution
Changed the recursive solution for one with a loop and builds out the string that way. Now the column size can grow to any length, though highly unlikely.
Test Plan
I added some simple test cases that demonstrate the problem and didn't previously exist for the function