Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRF Version and Validator Version Mismatch #121

Open
blakehice4 opened this issue Nov 5, 2024 · 2 comments
Open

MRF Version and Validator Version Mismatch #121

blakehice4 opened this issue Nov 5, 2024 · 2 comments

Comments

@blakehice4
Copy link
Contributor

I believe there was an update done to automatically pull version from the MRF and use that in the validator tool.
This logic does not handle the use case where the MRF version does not have a v prefix.
image

image

Can a modification be made to automatically handle versions without the v prefix like what is shown here https://github.com/CMSgov/price-transparency-guide/blob/0374c479ed146aa3c62e6460012b37fcaa3e5288/examples/in-network-rates/in-network-rates-fee-for-service-single-plan-sample.json#L9

@blakehice4 blakehice4 changed the title MRF Version mismatch MRF Version and Validator version mismatch Nov 5, 2024
@blakehice4 blakehice4 changed the title MRF Version and Validator version mismatch MRF Version and Validator Version Mismatch Nov 5, 2024
@blakehice4
Copy link
Contributor Author

looks like the version is pulled from git tags. i'm thinking in here we can add some logic to include versions without the v?

.filter(tag => tag.length > 0);

blakehice4 added a commit to blakehice4/price-transparency-guide-validator that referenced this issue Nov 5, 2024
blakehice4 added a commit to blakehice4/price-transparency-guide-validator that referenced this issue Nov 5, 2024
@blakehice4
Copy link
Contributor Author

was a little more complex than i thought. i think i have a decent start here
https://github.com/CMSgov/price-transparency-guide-validator/pull/122/files

shaselton-usds pushed a commit that referenced this issue Dec 6, 2024
* MRF Version and Validator Version Mismatch

#121

* MRF Version and Validator Version Mismatch
#121

* MRF Version and Validator Version Mismatch
updating version

* Apply formatting rules, update test descriptions

---------

Co-authored-by: mint thompson <mathompson@mitre.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant