Skip to content

Commit

Permalink
[QPPA-1362] Update QCDR measures with changes from PIMMS (#97)
Browse files Browse the repository at this point in the history
This PR updates the QCDR measures with changes since 10/25.

- [x] Manually update the updated PIMMS QCDR spreadsheet to include multiPerformanceRate strata changes from QPPA-1310
- [x] Incorporate the 164 changes to the PIMMS QCDR spreadsheet since 10/25
- [x] Define strata names for the four new measures which are newly proportional/multiPerformanceRate measures (MICS1, MICS2, MICS3, RCOIR1)
- [x] Send email to ask for future updates to include multiPerformanceRate strata changes

Also:
- I'm removing the old PIMMS QCDR spreadsheets; I think it makes more sense to keep updating qcdr-measures.csv with new changes, so that diffs are useful. 
- The qcdr-measures.csv has been uploaded to the jira ticket as `2017 PIMMS QCDR measures v4`

Jira: https://jira.cms.gov/browse/QPPA-1362

Tests: Still passes all tests

Reviewer: @kencheeto
  • Loading branch information
kalvinwang authored Nov 22, 2017
1 parent 7ba3d78 commit e7ab398
Show file tree
Hide file tree
Showing 10 changed files with 3,759 additions and 17,276 deletions.
420 changes: 234 additions & 186 deletions measures/measures-data.json

Large diffs are not rendered by default.

749 changes: 397 additions & 352 deletions measures/measures-data.xml

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "qpp-measures-data",
"version": "1.0.0-alpha.20",
"version": "1.0.0-alpha.21",
"description": "Quality Payment Program Measures Data Repository",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion scripts/measures/build-measures
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

qcdr_csv='../../util/measures/QCDR-Measures-20171109.csv'
qcdr_csv='../../util/measures/qcdr-measures.csv'
qcdr_strata_names='../../util/measures/qcdr-measures-strata-names.json'
staging_measures='../../staging/measures-data.json'
staging_measures_with_qcdrs='../../staging/measures-data-with-qcdrs.json'
Expand Down
9 changes: 7 additions & 2 deletions scripts/measures/import-qcdr-measures.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ const addMultiPerformanceRateDetails = function(newMeasure, record, qcdrStrataNa

// Add the names and descriptions of strata
let strataName;
const measureId = _.trim(record[2]);
const measureId = record[2].replace(/\s/g, ''); // "MOA 1" becomes "MOA1"
const measureDescription = _.trim(record[4]);

// Measure description column contains performance rate description
Expand All @@ -118,12 +118,17 @@ const addMultiPerformanceRateDetails = function(newMeasure, record, qcdrStrataNa

newMeasure['strata'] = [];
_.each(strata, function(stratum, index) {
if (_.isUndefined(qcdrStrataNames[measureId])) {
throw TypeError('Missing strata for ' + measureId + '. Should' +
'be in ' + qcdrStrataNamesDataPath + ', but isn\'t.');
}
strataName = qcdrStrataNames[measureId][index];

// i + 1 because Rates in the csv are numbered starting from 1
if (_.lowerCase(strataName) === 'overall' &&
index + 1 !== nthPerformanceRate) {
throw TypeError('"Overall" strata for ' + measureId + ' in QCDR ' +
'CSV doesn\'t match the name in the strata details file');
'CSV doesn\'t match the name in ' + qcdrStrataNamesDataPath);
}
newMeasure['strata'].push({
'name': strataName,
Expand Down
420 changes: 234 additions & 186 deletions staging/measures-data-with-qcdrs.json

Large diffs are not rendered by default.

6,840 changes: 0 additions & 6,840 deletions util/measures/20170825-PIMMS-non-mips_measure_specifications.csv

This file was deleted.

6,840 changes: 0 additions & 6,840 deletions util/measures/QCDR-Measures-20170911.csv

This file was deleted.

6 changes: 5 additions & 1 deletion util/measures/qcdr-measures-strata-names.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,9 @@
"NPA4": ["baseline", "overall"],
"NPA5": ["baseline", "overall"],
"ICLOPS15": ["withoutexcess", "withexcess"],
"ICLOPS17": ["withfollowup", "withoutfollowup"]
"ICLOPS17": ["withfollowup", "withoutfollowup"],
"MICS1": ["postsurvey", "overall"],
"MICS2": ["postsurvey", "overall"],
"MICS3": ["postsurvey", "overall"],
"RCOIR1": ["CKD3", "CKD4", "CKD5"]
}
5,747 changes: 2,880 additions & 2,867 deletions util/measures/QCDR-Measures-20171109.csv → util/measures/qcdr-measures.csv

Large diffs are not rendered by default.

0 comments on commit e7ab398

Please sign in to comment.