QPPC-6017: Docker Source cleanup, Update measures, mvp data #763
Conversation
mike-tekavec
requested review from
saquino0827,
KyleApfel,
sivaksb and
Jpec07
as code owners
There was a problem hiding this comment.
Mathematica's new file (v7.0_1.29.24.csv) contains the additionalProcedure code we need for C2Q
There was a problem hiding this comment.
The single source json file created from the new CSV adds the additionalProcedureCode. There are additional differences in the order of elements in the peformanceOptions array but this does not impact (will confirm) C2Q results
There was a problem hiding this comment.
Yeah it appears that way. We (claims) are the only ones that care about this file. The ordering causing more diffs in these might cause some pause, but otherwise I think mostly claims items were touched overall and looking good.
measures/2023/measures-data.json
mvp/2023/mvp-enriched.json
There was a problem hiding this comment.
Updates from the single source json file, similar additions/modifications here that occurred in that file.
There was a problem hiding this comment.
NB but thought of something, if we're not ready to remove, should we put a note in the old claims related items, that they're just for historical purposes? The old README for creating the single source, the py script for the same, and the few odds and ends. Auxilary scripts like clean_csv.py might not be such a big deal, but wouldn't want someone to catch the old README and make single source with old stuff.
Also, will help see if we can get the other eyes we'll need on this from outside claims.
|
Related Tickets & Documents
https://jira.cms.gov/browse/QPPC-6017
https://jira.cms.gov/browse/QPPC-6018
Description
Simplify the Docker image for creating the single source json file from Mathematica's single source CSV.
Update measures data
What type of PR is this?
Added tests?
Added to documentation?
[ ⌥ Optional ] Are there any post-deployment tasks we need to perform?