Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buggy State Converter Rewrite #4

Merged
merged 13 commits into from
Dec 29, 2024
Merged

Conversation

saransh323
Copy link

@saransh323 saransh323 commented Nov 6, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Rewrote/wrote a state converter node to convert raw_state to clean state for both SC and NAND. Benefits: unit and format conversion not done in arbitrary files anymore.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

Test this node by checking if the node converts raw values exactly as they were converted in pre-refactor code.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes: tested with simulation and rosbag data, checked if conversion/copying is correctly executed for NAND/self, SC/self, and SC/other
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

raw_state topics have to be created and published to

[optional] What gif best describes this PR or how it makes you feel?

alt_text

rb_ws/src/buggy/buggy/buggy_state_converter.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/buggy/buggy_state_converter.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/buggy/buggy_state_converter.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/buggy/buggy_state_converter.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/buggy/buggy_state_converter.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/buggy/buggy_state_converter.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/buggy/buggy_state_converter.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/buggy/buggy_state_converter.py Outdated Show resolved Hide resolved
mehulgoel873
mehulgoel873 previously approved these changes Dec 16, 2024
rb_ws/src/buggy/buggy/buggy_state_converter.py Outdated Show resolved Hide resolved
rb_ws/src/buggy/buggy/buggy_state_converter.py Outdated Show resolved Hide resolved
@mehulgoel873 mehulgoel873 merged commit d2064c8 into main Dec 29, 2024
3 checks passed
@mehulgoel873 mehulgoel873 deleted the buggy-state-converter-rewrite branch December 29, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants