forked from CMU-Robotics-Club/RoboBuggy2
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buggy State Converter Rewrite #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehulgoel873
requested changes
Nov 12, 2024
mehulgoel873
previously approved these changes
Dec 16, 2024
mehulgoel873
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Rewrote/wrote a state converter node to convert
raw_state
to cleanstate
for both SC and NAND. Benefits: unit and format conversion not done in arbitrary files anymore.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Test this node by checking if the node converts raw values exactly as they were converted in pre-refactor code.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
NAND/self
,SC/self
, andSC/other
have not been included
[optional] Are there any post deployment tasks we need to perform?
raw_state
topics have to be created and published to[optional] What gif best describes this PR or how it makes you feel?