Porting Ros2Bnyahaj #5
Open
+474
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added pyserial to project requirements - Added host_comm, pose, and world.py - Copied tf1 euler/quaternion conversion code to pose.py
mehulgoel873
requested changes
Dec 11, 2024
- Using scipy/utm package directly, removed dependency on pose/world.py - Added steering angle debug on publish - Standardizes use of rclpy.ok() instead of self.is_shutdown() - All packets are sent over debug telemetry
mehulgoel873
requested changes
Dec 12, 2024
…ossible swapping of packet x and y for ROS odom topic publishing.
mehulgoel873
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description/Changes
tf1euler/quaternion conversion code to pose.pytf2packagesQA Instructions, Screenshots, Recordings
Most likely will need to test with a fully integrated system
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included