🔀 :: (#12) 유저 유스케이스 SPI 브랜치로 병합 #14

iqpizza6349 · 2023-02-23T07:01:15Z

close #12

다룬 업무

API 를 구현한 구현체 UseCase 구현
return 이 존재하는 API 메소드 검증 테스트 진행

다른 모듈에 영향을 미친 점

Validation (Hibernate 8.0.0.Final) 라이브러리 추가
UseCase 테스트를 위한 Mockito 라이브러리 추가
보다 확장성을 높이기 위해 SPI 구조 변경
ERD 에 존재하지 않으나, 명세서상 요구되는 엔티티 추가 (Merit)

예정과 변경되거나 진행해야하는 작업

HTTP API 모듈은 Adapter 브랜치에서 따로 다룰 예정

* ✨ :: (#11) Create type enums for Applicant Domain * ➕ :: (#11) Add dependency for Domain Layer * ✨ :: (#11) Create entities * ✨ :: (#11) Create domain objects * 🔥 :: (#11) Delete temporary file * ✨ :: (#11) Create mappers * ➕ :: (#11) Add dependency 'Spi-Common' * 🔥 :: (#11) Remove temporary files * 🐛 :: (#11) Make ApplicantInfoEntity to implement Serializable

# Conflicts: # User-Domain/src/main/java/com/dgsw/cns/user/spi/UserRegistrationSpi.java

User-Domain/src/main/java/com/dgsw/cns/user/domain/Member.java

ericlee05

코드 작성하시고 테스트 케이스까지 작성하시느라 정말 수고 많으셨습니다! :)

PR을 보니 몇가지 협의하고 넘어가야 할 부분이 있는 거 같네욥..!

User-Domain/src/main/java/com/dgsw/cns/user/usecase/UserRegistrationUseCase.java

User-Domain/src/main/java/com/dgsw/cns/user/usecase/UserVeteranUseCase.java

User-Domain/src/main/java/com/dgsw/cns/user/usecase/cetification/UserRecoveryUseCase.java

sonarcloud · 2023-03-15T11:38:24Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
8 Code Smells

0.0% Coverage
0.0% Duplication

ericlee05 and others added 30 commits January 30, 2023 14:38

⚡ :: (#12) usecase 작성

ff56eed

Merge branch '10-user-spi' into 12-user-usecase

c82bc36

⚡ :: improve use-cases

006ef72

Merge branch '10-user-spi' into 12-user-usecase

0675003

# Conflicts: # User-Domain/src/main/java/com/dgsw/cns/user/spi/UserRegistrationSpi.java

💡 add comments in UserRecoveryUseCase

1da67b2

✅ :: add simple api test

6cd126b

Merge branch '10-user-spi' into 12-user-usecase

dde6e0e

🚩 :: (#12) update DI in UserRegistrationUseCase.java

b1ad0a5

➕ :: (#12) add new dependency(assertJ) in user domain test

4d410f6

✅ :: (#12) write get user info pass-test

e66b617

🚚 :: (#12) move email regex test in external package

d5b907f

🔥 :: remove unuseful test code

e07556b

🗃️ :: update entities, domains, mappers

da94e49

➕ :: (#12) add mockito dependencies

8484f01

⚡ :: (#12) add static factory methods

5ace573

🔥 :: (#12) remove useless spi (replaceable with query-spi)

729be33

📝 :: (#12) update comment (verify -> then)

c5c53bc

🎨 :: (#12) the deletion of spi replaced business logic with query spi

ad9f4d4

🧪 :: (#12) add user-info fail test case

c83d377

🧪 :: (#12) add user-parent-info fail test case

74892fa

📌 :: pin use-case dependencies

7acc011

👽 :: remove regex default-method

695fc32

♻️ :: add custom exception when occurred cause is member

80cf73e

♻️ :: refactor email test-code with validator

cdb20d7

⚡ :: add validation annotations

0a328cf

♻️ :: (#12) refactor use-case logic

e254bcc

🧪 :: (#12) add regex fail test-cases

1ca5c64

🧪 :: (#12) add user-registration use-case failing test

c8a3e69

👽 :: (#12) add validation annotations in field

b11acbd

iqpizza6349 added 5 commits February 22, 2023 20:41

✅ :: (#12) add UserVeteran field regex-test

c76dacb

✅ :: (#12) add UserRecovery-UseCase failing test

fdf0446

♻️ :: (#12) update exception standard to custom

c4782e9

♻️ :: (#12) add field validation annotations

2363d1e

📌 :: (#12) add jakarta.el library in spi_test dependency list

486c326

iqpizza6349 added 기능 새로운 기능이 왔어요 리팩토링 구조는 좋아져도 기능은 그대로! 핫픽스 긴급한 수정 labels Feb 23, 2023

iqpizza6349 requested review from ericlee05, pea06 and jiseok419 February 23, 2023 07:01

iqpizza6349 assigned iqpizza6349 and jiseok419 Feb 23, 2023

iqpizza6349 added 3 commits February 23, 2023 19:42

📌 :: (#12) add junit-parameterized-test dependency

c3a512a

♻️ :: (#12) refactor all-kind of code-smells

823078b

♻️ :: (#12) refactor sizeIsZero method to isEmpty method

0d88aa5

ericlee05 reviewed Feb 23, 2023

View reviewed changes

User-Domain/src/main/java/com/dgsw/cns/user/domain/Member.java Outdated Show resolved Hide resolved

ericlee05 reviewed Feb 23, 2023

View reviewed changes

iqpizza6349 added 6 commits February 23, 2023 22:56

♻️ :: (#12) rename method 'matches' to 'matchesVerificationCode'

c58a512

♻️ :: (#12) refactor method separation

e454095

🔀 :: (#15) Client Error Response 기반 예외 클래스 구현체 및 유틸 클래스 모듈 생성

32f0c87

Merge branch 'main' into 12-user-usecase

c10a65d

♻️ :: (#12) refactor domain-inner-exception classes

91909a1

📝 :: add README.MD

7bae300

ericlee05 self-requested a review March 15, 2023 11:39

ericlee05 approved these changes Mar 15, 2023

View reviewed changes

iqpizza6349 merged commit d1dfa21 into 10-user-spi Mar 15, 2023

ericlee05 deleted the 12-user-usecase branch March 15, 2023 11:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🔀 :: (#12) 유저 유스케이스 SPI 브랜치로 병합 #14

🔀 :: (#12) 유저 유스케이스 SPI 브랜치로 병합 #14

iqpizza6349 commented Feb 23, 2023

ericlee05 left a comment

sonarcloud bot commented Mar 15, 2023

🔀 :: (#12) 유저 유스케이스 SPI 브랜치로 병합 #14

🔀 :: (#12) 유저 유스케이스 SPI 브랜치로 병합 #14

Conversation

iqpizza6349 commented Feb 23, 2023

다룬 업무

다른 모듈에 영향을 미친 점

예정과 변경되거나 진행해야하는 작업

ericlee05 left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Mar 15, 2023