Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Generalize coala placeholder and re-introduce Manifestation #26

Merged
merged 2 commits into from
Sep 15, 2017

Conversation

TimDaub
Copy link
Contributor

@TimDaub TimDaub commented Sep 6, 2017

  • moved <coalaip placeholder> to top
  • Introduce new class Manifestation
  • Adjust schema readme

This change will produce changes downstream, mainly for:

  • js-coalaip
  • py-coalaip

@TimDaub TimDaub changed the title Generalize coala placeholder [wip] Generalize coala placeholder Sep 6, 2017
@TimDaub TimDaub requested a review from zbo14 September 6, 2017 11:43
@TimDaub TimDaub changed the title [wip] Generalize coala placeholder Generalize coala placeholder Sep 6, 2017
Copy link

@zbo14 zbo14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimDaub looks great! Just curious why you chose to subclass Manifestation from AbstractWork instead of from CreativeWork

@@ -172,7 +181,7 @@
"rdfs:label": "fingerprint"
},
{
"@id": "<coalaip placeholder>/manifestationOfWork",
"@id": "coala:manifestationOf",
"@type": "rdf:Property",
"schema:domainIncludes": {
"@id": "schema:CreativeWork"
Copy link

@zbo14 zbo14 Sep 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should schema:CreativeWork be coala:Manifestation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I corrected it.

- rename: manifestationOfWork => manifestationOf
@TimDaub TimDaub changed the title Generalize coala placeholder Generalize coala placeholder and re-introduce Manifestation Sep 15, 2017
@TimDaub TimDaub force-pushed the separate-manifestation branch from ec0e795 to ca15c20 Compare September 15, 2017 08:18
@TimDaub TimDaub merged commit 975d966 into master Sep 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants