This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Change Copyright to rightType: Copyright #29
Open
TimDaub
wants to merge
5
commits into
master
Choose a base branch
from
remove-copyright
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -502,16 +502,6 @@ As no existing schema.org vocabulary fits the RRM's notion of a `Right` or [COAL | |
`Copyright`](#link-me), we define our own classes with the following vocabulary: | ||
|
||
```javascript | ||
// Copyright Class | ||
{ | ||
"@id": "<coalaip placeholder>/Copyright", | ||
"@type": "rdfs:Class", | ||
"rdfs:subClassOf": { | ||
"@id": "schema:Intangible" | ||
}, | ||
... | ||
} | ||
|
||
// Right Class | ||
{ | ||
"@id": "<coalaip placeholder>/Right", | ||
|
@@ -582,7 +572,7 @@ As no existing schema.org vocabulary fits the RRM's notion of a `Right` or [COAL | |
"@id": "<coalaip placeholder>/rightsOf", | ||
"@type": "rdf:Property", | ||
"schema:domainIncludes": { | ||
"@id": "coala:Copyright" | ||
"@id": "coala:Right" | ||
}, | ||
"schema:rangeIncludes": { | ||
"@id": "schema:CreativeWork" | ||
|
@@ -593,34 +583,13 @@ As no existing schema.org vocabulary fits the RRM's notion of a `Right` or [COAL | |
... | ||
} | ||
|
||
// Source Property | ||
{ | ||
"@id": "<coalaip placeholder>/source", | ||
"@type": "rdf:Property", | ||
"schema:domainIncludes": { | ||
"@id": "coala:Right" | ||
}, | ||
"schema:rangeIncludes": { | ||
"@id": "coala:Copyright" | ||
}, | ||
"owl:equivalentProperty": { | ||
"@id": "dc:source" | ||
}, | ||
... | ||
} | ||
|
||
// Territory Property | ||
{ | ||
"@id": "<coalaip placeholder>/territory", | ||
"@type": "rdf:Property", | ||
"schema:domainIncludes": [ | ||
{ | ||
"@id": "coala:Copyright" | ||
}, | ||
{ | ||
"schema:domainIncludes": { | ||
"@id": "coala:Right" | ||
} | ||
], | ||
}, | ||
"schema:rangeIncludes": { | ||
"@id": "schema:Place" | ||
}, | ||
|
@@ -648,9 +617,6 @@ As no existing schema.org vocabulary fits the RRM's notion of a `Right` or [COAL | |
"@id": "<coalaip placeholder>/validFrom", | ||
"@type": "rdf:Property", | ||
"schema:domainIncludes": [ | ||
{ | ||
"@id": "coala:Copyright" | ||
}, | ||
{ | ||
"@id": "coala:Right" | ||
}, | ||
|
@@ -677,9 +643,6 @@ As no existing schema.org vocabulary fits the RRM's notion of a `Right` or [COAL | |
"@id": "<coalaip placeholder>/validThrough", | ||
"@type": "rdf:Property", | ||
"schema:domainIncludes": [ | ||
{ | ||
"@id": "coala:Copyright" | ||
}, | ||
{ | ||
"@id": "coala:Right" | ||
}, | ||
|
@@ -711,7 +674,7 @@ As no existing schema.org vocabulary fits the RRM's notion of a `Right` or [COAL | |
registrar of a `Right` | ||
- `schema.org/license` can be used to provide a URL to the legal license document covering a `Right` | ||
|
||
An example of a `Copyright` and a derived `Right`: | ||
An example of a `rightType: Copyright` and a derived `Right`: | ||
|
||
```javascript | ||
// Note: We assume that the data will be put on an immutable ledger, forcing all links to point "backwards." | ||
|
@@ -724,8 +687,9 @@ An example of a `Copyright` and a derived `Right`: | |
"http://schema.org/", | ||
"<coalaip placeholder>" | ||
], | ||
"@type": "<coalaip placeholder>/Copyright", | ||
"@type": "<coalaip placeholder>/Right", | ||
"@id": "<URI pointing to this object>", | ||
"rightType": "Copyright", | ||
"rightsOf": "<URI pointing to a CreativeWork object (usually should be a Manifestation)>", | ||
"territory": "<URI pointing to a Place object>", | ||
"validFrom": "2016-01-01", | ||
|
@@ -740,7 +704,7 @@ An example of a `Copyright` and a derived `Right`: | |
], | ||
"@type": "<coalaip placeholder>/Right", | ||
"@id": "<URI pointing to this object>", | ||
"source": "<URI pointing to a Copyright object>", | ||
"rightsOf": "<URI pointing to a Copyright object>", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For example this line There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I hope I made this more clear in 5343372 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes! Okay I understand now. Looks good to me! |
||
"usageType": ["all", "copy", "play"], | ||
"territory": "<URI pointing to a Place object>", | ||
"rightContext": ["inflight", "inpublic", "commercialuse"], | ||
|
@@ -759,7 +723,7 @@ An example of a `Copyright` and a derived `Right`: | |
"http://schema.org/", | ||
"<coalaip placeholder>" | ||
], | ||
"@type": "<coalaip placeholder>/Copyright", | ||
"@type": "<coalaip placeholder>/Right", | ||
"rightsOf": { "/": "<hash pointing to a CreativeWork object (that should be a Manifestation)>" }, | ||
"territory": { "/": "<hash pointing to a Place object>" }, | ||
"validFrom": "2016-01-01", | ||
|
@@ -773,7 +737,7 @@ An example of a `Copyright` and a derived `Right`: | |
{ "/": "<hash pointing to COALA IP's context>" } | ||
], | ||
"@type": "<coalaip placeholder>/Right", | ||
"source": { "/": "<hash pointing to a Copyright object>" }, | ||
"rightsOf": { "/": "<hash pointing to a Copyright object>" }, | ||
"usageType": ["all", "copy", "play"], | ||
"territory": { "/": "<hash pointing to a Place object>" }, | ||
"rightContext": ["inflight", "inpublic", "commercialuse"], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this generally makes good sense to me, although I'm still a little bit confused because in some instances
rightsOf
is said to point to aCreativeWork
and in others it still says that it points to a URI of aCopyright
object. Wouldn't Copyright objects no longer exist if that schema is removed from the spec?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think an example of what what a
rightsOf
property could point to would help clarify here. For example in the case of Ujo we are issuingRight
objects that referenceMusicRecording
objects. WouldrightOf
point to the MusicRecording object in JSON format, or a legal document that is hashes and stored on chain? At the moment in our implementation we are not populating this field due to this uncertainty. We are hoping to migrate the data to be inline with the spec though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another potentially related question here is how Rights are expected to be referenced from a
CreativeWork
. In other words, if I have aCreativeWork
object, should it contain an array ofRight
objects? In our case this is how we handle it in order to referencepercentageShares
on aMusicRecording
and then split payments that are made on chain. This seems like a common usecase for theseRight
objects, but the way we are handling it currently seems potentially out of line with this spec.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this PR I'm proposing to not completely the concept of Copyright but to make it part of the Right entity by introducing a
rightType: Copyright
, like proposed in the RRM.rightOf
would always point to the MusicRecording object in JSON format. We have the propertylicense
inRight
that points to the legal document.@vrde and I stumped upon the same issue when we did some work for the OMI: #24 I'm afraid we currently don't have a good answer in the specification for this problem. Additionally, it's specific to the blockchain or DLT you're saving the Right onto. IPFS e.g. is not searchable, so backward pointing links are required. Other solutions might one day be available where searching is possible. Until then, we need a makeshift solution. @alexanderattar would you mind adding this use case somewhere in this repo as an issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha..okay yeah that makes sense. I'm happy to open a separate issue for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here we go: #31