Fix SonarQube High severity issues: string duplication and cognitive complexity #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…complexity - Replace duplicated string 'failed to get GitHub client: %w' with ErrFailedToGetGitHubClient constant (12 occurrences) - Replace duplicated strings 'Repository owner'/'Repository name' with DescRepositoryOwner/DescRepositoryName constants (17 occurrences each) - Refactor main function in cmd/mcpcurl/main.go to reduce cognitive complexity by extracting helper functions - Refactor GetFileContents function in pkg/github/repositories.go to reduce cognitive complexity by extracting 6 focused helper functions All changes maintain existing functionality and pass all tests. Co-Authored-By: Eashan Sinha <eashan.sinha@codeium.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…nitive complexity - Add RepoURIScheme constant to eliminate 'repo://' string duplication - Refactor loadToolsFromServer function to use early returns, reducing cognitive complexity from 16 to under 15 - Replace nested if-else chains with early return pattern for better readability - All original SonarQube fixes remain intact and functional Co-Authored-By: Eashan Sinha <eashan.sinha@codeium.com>
- Replace all remaining hardcoded 'repo://' strings in resource templates and tests with RepoURIScheme constant - Updated repository_resource.go: 5 template definitions now use RepoURIScheme - Updated repository_resource_test.go: 4 test assertions now use RepoURIScheme - Updated repositories_test.go: 2 test expectations now use RepoURIScheme - This should reduce code duplication below the 3% SonarQube threshold - All tests pass and build is successful Co-Authored-By: Eashan Sinha <eashan.sinha@codeium.com>
…t.Sprintf usage - Consolidate all error message constants in actions.go - Replace hardcoded error strings with shared constants across pkg/github - Fix fmt.Sprintf usage with %w directive by using fmt.Errorf - Target high-impact duplications: 'failed to marshal response', 'Repository owner/name', etc. - Reduces code duplication to meet SonarCloud requirements Co-Authored-By: Eashan Sinha <eashan.sinha@codeium.com>
…resource.go - Replace hardcoded 'failed to read response body: %w' with ErrFailedToReadResponseBody constant - Ensures consistency with other error handling across pkg/github Co-Authored-By: Eashan Sinha <eashan.sinha@codeium.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 4 High severity SonarQube issues by addressing string duplication (go:S1192) and cognitive complexity (go:S3776) problems identified in the codebase.
Requested by: @eashansinha
Devin session: https://app.devin.ai/sessions/7f34a5c6f77949e1868ae5ef163f4e79
Changes Made
String Duplication Fixes (go:S1192)
ErrFailedToGetGitHubClientconstantDescRepositoryOwnerandDescRepositoryNameconstantsCognitive Complexity Fixes (go:S3776)
mainfunction incmd/mcpcurl/main.go- Refactored into 4 focused helper functions:setupRootCommand()- Command setup and flag parsinggetPrettyPrintFlag()- Flag retrieval with error handlingloadToolsFromServer()- Schema fetching and tool generationexecuteRootCommand()- Command executionGetFileContentsfunction inpkg/github/repositories.go- Broke down 130+ line function into 6 helper functions:extractFileContentsParams()- Parameter validationbuildRawContentOpts()- Pull request reference processingtryGetRawFileContent()- Raw file content fetchingbuildFileContentResult()- Response building for filesbuildResourceURI()- Resource URI constructiongetDirectoryContent()- Directory content fetchingTesting
go test ./...)GetFileContentstests verifiedgo build ./...)Review Focus Areas
Medium Priority:
Tradeoffs
The refactoring maintains 100% functional equivalence while significantly reducing cognitive complexity and eliminating string duplication as identified by SonarQube.