MBA-244: Replace Logrus with slog in server initialization #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace github.com/sirupsen/logrus import with log/slog in server.go - Update logger creation to use slog.New() with slog.NewTextHandler() for file logging - Use slog.Default() when no log file path is specified - Replace logrusLogger.Writer() bridge with slog.NewLogLogger() for stdlib compatibility - Update shutdown logging to use logger.Info() instead of logrusLogger.Infof() - Update IOLogger interface in pkg/log/io.go to accept *slog.Logger instead of *logrus.Logger - Change IOLogger logging methods to use structured logging with key-value pairs - Update IOLogger tests to use slog.NewTextHandler() instead of logrus setup - Remove unused standard library log import All existing logging functionality is preserved while migrating to Go's standard slog package. Co-Authored-By: Jake Cosme <jake@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
After migrating to slog, the github.com/sirupsen/logrus dependency is no longer needed and has been removed by go mod tidy. Co-Authored-By: Jake Cosme <jake@cognition.ai>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MBA-244
Summary
This PR migrates the GitHub MCP server from the Logrus logging library to Go's standard library
log/slogpackage. The migration maintains existing functionality while modernizing the logging infrastructure and removing an external dependency.Key Changes:
github.com/sirupsen/logruswithlog/slogin server initializationImplementation Details
Server Logging (
internal/ghmcp/server.go):slog.New()with conditional file handler vsslog.Default()slog.NewTextHandler()with debug levelslog.NewLogLogger()instead oflogrus.Writer()logrusLogger.Infof()tologger.Info()IOLogger Migration (
pkg/log/io.go):*slog.Loggerinstead of*logrus.Loggerl.logger.Infof("[stdin]: received %d bytes: %s", n, data)→l.logger.Info("[stdin]", "received_bytes", n, "data", data)l.logger.Infof("[stdout]: sending %d bytes: %s", len(p), data)→l.logger.Info("[stdout]", "sending_bytes", len(p), "data", data)Tradeoffs
Taken On:
Paid Down:
slog.NewLogLogger()provides equivalent functionality to previouslog.New(logrusLogger.Writer())Session: https://app.devin.ai/sessions/559e5a86ce774440ab207ce212e315a4
Requested by: @jakexcosme