Fix SonarQube high-severity issues: string duplication and cognitive complexity #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…complexity - Fixed string literal duplication in pkg/github/search.go * Added constants for 'failed to read response body: %w' and 'failed to marshal response: %w' * Replaced 4 duplicate occurrences with constant references - Reduced cognitive complexity in cmd/mcpcurl/main.go * Refactored main() function from complexity 18 to under 15 * Extracted schema loading logic into loadSchemaAndGenerateCommands() function - Reduced cognitive complexity in pkg/github/search.go * Refactored userOrOrgHandler from complexity 40 to under 15 * Extracted parameter extraction into extractSearchParams() function * Extracted API call logic into performUserSearch() function * Extracted error handling into handleNon200Response() function * Extracted result building into buildMinimalSearchResult() function * Extracted marshaling into marshalSearchResult() function All tests pass and linting is clean. Co-Authored-By: Eashan Sinha <eashan.sinha@codeium.com>
devin-ai-integration
bot
force-pushed
the
devin/1759474902-fix-sonarqube-issues
branch
from
ac162ee to
e5cd66d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses 4 high-severity SonarQube issues in the github-mcp-server repository:
Changes
String Duplication Fixes (pkg/github/search.go)
Issue: String literals "failed to read response body: %w" and "failed to marshal response: %w" were duplicated 3-4 times each.
Solution:
errReadResponseBodyanderrMarshalResponseCognitive Complexity Reductions
1. cmd/mcpcurl/main.go (Complexity: 18 → <15)
Issue: The
main()function had cognitive complexity of 18, exceeding the threshold of 15.Solution:
loadSchemaAndGenerateCommands()function2. pkg/github/search.go (Complexity: 40 → <15)
Issue: The
userOrOrgHandlerfunction had cognitive complexity of 40, far exceeding the threshold of 15.Solution:
extractSearchParams()functionperformUserSearch()functionhandleNon200Response()functionbuildMinimalSearchResult()functionmarshalSearchResult()functionTesting
go test -v ./...)./script/lint)SonarQube Issues Addressed
pkg/github/search.gopkg/github/search.gocmd/mcpcurl/main.go:155pkg/github/search.go:176Link to Devin run: https://app.devin.ai/sessions/ceeb3d7d08fd442287dac90a0405cd58
Requested by: Eashan Sinha (eashan.sinha@cognition.ai) (@eashansinha)