Fix SonarQube High severity issues: string duplication and cognitive complexity #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two High severity SonarQube issues in
pkg/github/repositories.go:"failed to get GitHub client: %w"that appeared 12 times across the fileListCommitsfunction from 23 to below the threshold by extracting handler logicChanges
String Duplication Fix
errFailedToGetGitHubClientat package levelGetCommit,ListCommits,ListBranches,CreateOrUpdateFile,CreateRepository,GetFileContents,ForkRepository,DeleteFile,CreateBranch,PushFiles,ListTags,GetTagCognitive Complexity Fix
ListCommitsinto standalonelistCommitsHandlerhelper functionListCommitsnow delegates tolistCommitsHandler, reducing nesting and complexityTesting
Review Checklist
listCommitsHandlermaintains exact same behavior as original inline handlerNotes
Link to Devin run: https://app.devin.ai/sessions/7404ee489c2448e0a734739b9c018809
Requested by: Shawn Azman (shawn@cognition.ai) / @ShawnAzman