Update Core Java & Build Configuration for Java 11 Migration #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update java.version property from 1.8 to 11 - Add Maven compiler plugin configuration with source, target, and release set to 11 - Verified Maven wrapper files (mvnw, mvnw.cmd) exist in repository root - Compilation and tests pass successfully with Java 11 Co-Authored-By: Jaime Mizrachi <jaime@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
bot
changed the base branch from
dependabot/maven/io.springfox-springfox-swagger-ui-2.10.0
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Core Java & Build Configuration for Java 11 Migration
Summary
This PR implements Component 1 of the Java 8 to Java 11 migration plan by updating only the Maven build configuration to target Java 11. No dependencies or application code have been modified.
Changes:
java.versionproperty from1.8to11(pom.xml line 18)source,target, andreleaseall set to11(pom.xml lines 82-90)mvnw,mvnw.cmd) exist in repository rootVerification performed:
mvn clean compile)mvn test- 1 test, 0 failures)Review & Testing Checklist for Human
Critical items to verify before merging:
CI/CD environments use Java 11+ - The
--releaseflag requires Maven to run with JDK 9 or higher. Builds will fail with "invalid flag: --release" if Maven is running on Java 8. Update CI/CD configurations accordingly.Test full application functionality - Only basic context loading was tested. Run the application with Java 11 and verify all banking operations work correctly:
mvn spring-boot:run(with JAVA_HOME set to Java 11)Deployment environment readiness - Confirm staging/production environments are configured to use Java 11 runtime (not just build time)
Scope alignment - Verify this matches expected scope: build configuration only, NO dependency upgrades (Spring Boot 2.1.4 remains unchanged as intended for separate task)
Notes
Link to Devin run: https://app.devin.ai/sessions/e6399634e33243f68ed962bafb659f83
Requested by: Jaime Mizrachi (@jaime-leo)