Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way of dynamically extending the list of measurement units given in the DDLm reference dictionary? #385

Closed
vaitkus opened this issue May 8, 2023 · 2 comments
Labels

Comments

@vaitkus
Copy link
Collaborator

vaitkus commented May 8, 2023

The DDLm language was successfully applied outside the field of crystallography to create dictionaries that describe Raman spectroscopy experiments (see [1]). However, during the development of these dictionaries several new units of measurement which are not defined in the DDLm reference dictionary, were introduced (e.g. arbitrary_units, lines_per_millimetre).

I was wondering if there is a way of dynamically adding these units in an instance dictionary or would this necessarily require the modification of the DDLm dictionary itself, e.g. by using a patched version of the templ_enum.cif file?

[1] https://github.com/cod-developers/cif_raman/blob/master/dictionaries/cif_raman_0.3.3.dic

@jamesrhester
Copy link
Contributor

There is currently no way to do this dynamically, given that the units list forms part of the upper ontology by being imported into the dictionary describing the DDLm language. However, the developers of the Raman spectroscopy dictionary are welcome to submit a PR to templ_enum.cif. Part of the idea of putting the units into a separate file in this way is to make it easier to expand the list.

@vaitkus
Copy link
Collaborator Author

vaitkus commented Jun 28, 2023

Thank you for the clarification. I will relay the issue to the developers of the Raman spectroscopy dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants