Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose additional units to the DDLm reference dictionary #2

Open
vaitkus opened this issue Jun 28, 2023 · 0 comments
Open

Propose additional units to the DDLm reference dictionary #2

vaitkus opened this issue Jun 28, 2023 · 0 comments

Comments

@vaitkus
Copy link
Member

vaitkus commented Jun 28, 2023

The CIF_RAMAN dictionary version 0.3.3 uses several units of measurement that are not among the units allowed by the DDLm reference dictionary [1]. While currently there is no formal way of defining dictionary-specific units, the developers of DDLm are quite open to the idea of including the missing units in the reference dictionary (see discussion in issue [2]).

Additional units should be suggested in the form of a PR. Specifically, proper descriptions of the milliwatts, lines_per_millimetre and arbitrary_units units should be added to the templ_enum.cif file.

[1] https://github.com/COMCIFS/cif_core/blob/master/ddl.dic
[2] COMCIFS/cif_core#385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant