Manage dependencies with Poetry #605
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of me attempting to modernize the CONP Portal's python dependencies and make sure they're all mutually compatible. I'd hoped to verify that everything works with this on portal-dev, but I'm not optimistic that boutiques/boutiques#656 will be merged by the end of the day today, so I wanted to put this PR out there.
The approach I took here was to adopt Poetry as the dependency manager for this project. The feature I particularly wanted was Poetry's ability to take a list of requirements (including Python version) and produce a "lock file" with mutually compatible versions of those requirements -- this made reconciling the dependencies a lot more manageable. Some old dependencies are no longer maintained, so I had to make some minor changes to the code to accommodate a replacement.
Note: you can still install the dependencies from a clone of this repository with
pip install -e ., which is what I've done on portal-dev for now.I hope managing the Poetry stuff won't be much more of a burden than the
requirements.txtand will make it easier to tell if there are any issues with the dependencies.