Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highs mods #17

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Highs mods #17

wants to merge 6 commits into from

Conversation

jajhall
Copy link

@jajhall jajhall commented Feb 14, 2024

Here are almost all the modifications that I've made so that cuPDLP-C can be run from HiGHS. The issues that I've had are set out in README.md. The modifications have been written so that the original cuPDLP-C behaviour is retained when these files are used in https://github.com/COPT-Public/cuPDLP-C

The changes that I've not included are those relating to cmake, since I can't code them so that the original cuPDLP-C behaviour is retained. I'll simply have to re-do them as/when I pull and changes that are made to https://github.com/COPT-Public/cuPDLP-C

@jajhall
Copy link
Author

jajhall commented Feb 16, 2024

When adding two more settings to INT_USER_PARAM, I got CI failures until I spotted that N_INT_USER_PARAM and N_FLOAT_USER_PARAM are set explicitly rather than implicitly as the last entry in the enum. Doing the latter seems to be much better practice

@bzhangcw
Copy link
Collaborator

Seem to be problematic with the GPU version. Maybe stage it as a new branch and merge it later? @SkyLiu0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants