New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cashback debugging #1022

Open

gohanman opened this issue May 30, 2019 · 1 comment

Contributor

gohanman commented May 30, 2019

[Note to self]

Is Paycards cashback too lax? Need to verify cashback gets carried through as cashback when it's allowed to be added on.

EmvPage => Request => E2E flow.

gohanman added a commit that referenced this issue


Standardize cashback type-check #1022

e8d822b

Contributor Author

gohanman commented Jun 4, 2019

The behavior here was laxer than it should be. Pulling the logic into CardValidator::allowCashback should make for more consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment