Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/render #441

Merged
merged 104 commits into from
Sep 30, 2024
Merged

Feat/render #441

merged 104 commits into from
Sep 30, 2024

Conversation

Douglasj02
Copy link
Contributor

No description provided.

Copy link

gitguardian bot commented Sep 30, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13964749 Triggered Generic Password b06991a Frontend/src/app/components/templates/desktop/desk-register/desk-register.component.spec.ts View secret
13964749 Triggered Generic Password b06991a Frontend/src/app/components/templates/desktop/desk-register/desk-register.component.spec.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

@Divergent-Caesar Divergent-Caesar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roses are red
violets are blue
I have not read your code
but your stuff is approved

@Douglasj02 Douglasj02 merged commit 90b1837 into main Sep 30, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants