Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/integration on page seo #260

Merged
merged 24 commits into from
Jul 25, 2024

Conversation

MignonErasmus
Copy link
Contributor

@MignonErasmus MignonErasmus commented Jul 25, 2024

Description

UI and integration for on page SEO analysis

Changes Made

  • Added necessary unit tests
  • UI and integration for on page SEO analysis (commented out recommendations in frontend and testing)

Screenshots (if applicable)

image

Related Issues

#236

Checklist

  • I have tested this code locally
  • I have reviewed the code for readability and maintainability
  • I have added appropriate documentation or updated existing documentation
  • I have ensured that my changes follow the project's coding conventions
  • I have performed additional steps, if required [e.g., database migrations, configuration changes, etc.]

Additional Notes

I will create another PR where i will fix the following UI problems:
Issue: #261

Tabs to be responsive on mobile + change colours to match our website
image

Deal with a list of headings:
image

Center it properly:
image

Add vertical padding:
image

Add i buttons to explain each SEO analysis criteria

@MignonErasmus MignonErasmus added enhancement New feature or request integration Integration of new feature labels Jul 25, 2024
@MignonErasmus MignonErasmus added this to the Demo 3 milestone Jul 25, 2024
@MignonErasmus MignonErasmus self-assigned this Jul 25, 2024
@MignonErasmus MignonErasmus linked an issue Jul 25, 2024 that may be closed by this pull request
@MignonErasmus MignonErasmus marked this pull request as draft July 25, 2024 11:07
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 91.52542% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.27%. Comparing base (0b05d96) to head (f62a9a2).
Report is 33 commits behind head on development.

Files Patch % Lines
wee/frontend/src/app/(pages)/results/page.tsx 91.52% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #260      +/-   ##
===============================================
+ Coverage        87.92%   88.27%   +0.35%     
===============================================
  Files               40       41       +1     
  Lines             1755     1833      +78     
  Branches           402      428      +26     
===============================================
+ Hits              1543     1618      +75     
- Misses             205      208       +3     
  Partials             7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MignonErasmus MignonErasmus marked this pull request as ready for review July 25, 2024 13:37
@MignonErasmus MignonErasmus requested a review from CaitMS July 25, 2024 13:38
@MignonErasmus MignonErasmus merged commit 45d2f0e into development Jul 25, 2024
3 of 4 checks passed
@MignonErasmus MignonErasmus deleted the feature/integration-on-page-seo branch August 12, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request integration Integration of new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI + Integration: On-page SEO analysis for individual result page
2 participants