Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/backend/pfps #234

Merged
merged 3 commits into from
Jul 20, 2024
Merged

Feat/backend/pfps #234

merged 3 commits into from
Jul 20, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Jul 20, 2024

Description

This pr introduces pfps. nothing more...nothing less

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Could only test such functionality with postman

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: feature A new feature For: api This is mainly for the api For: backend This is mainly for the backend code priority: low This does/did not need to be addressed any time soon effort: 5 This may require/required hours of work labels Jul 20, 2024
@waveyboym waveyboym added this to the Week 3 Sprint 3 milestone Jul 20, 2024
@waveyboym waveyboym self-assigned this Jul 20, 2024
@waveyboym
Copy link
Member Author

coverage will be in the hood lol

@waveyboym waveyboym merged commit d7b0c6e into develop Jul 20, 2024
4 checks passed
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 0.71429% with 139 lines in your changes missing coverage. Please review.

Project coverage is 59.60%. Comparing base (531558d) to head (bed657d).
Report is 3 commits behind head on develop.

Files Patch % Lines
occupi-backend/pkg/database/database.go 0.00% 88 Missing ⚠️
occupi-backend/pkg/utils/utils.go 0.00% 37 Missing ⚠️
occupi-backend/pkg/middleware/middleware.go 6.66% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #234      +/-   ##
===========================================
- Coverage    65.04%   59.60%   -5.44%     
===========================================
  Files            8        8              
  Lines         1496     1634     +138     
===========================================
+ Hits           973      974       +1     
- Misses         486      622     +136     
- Partials        37       38       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym waveyboym deleted the feat/backend/pfps branch July 20, 2024 20:09
waveyboym added a commit that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 This may require/required hours of work For: api This is mainly for the api For: backend This is mainly for the backend code priority: low This does/did not need to be addressed any time soon type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant