Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/backend/self implemented counter #357

Merged
merged 14 commits into from
Sep 12, 2024

Conversation

Rethakgetse-Manaka
Copy link
Contributor

@Rethakgetse-Manaka Rethakgetse-Manaka commented Sep 10, 2024

Description

Integrated the real-time counter
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Rethakgetse-Manaka Rethakgetse-Manaka added For: frontend This is mainly related to frontend UI code For: api This is mainly for the api For: backend This is mainly for the backend code priority: high This needs/needed to be addressed as soon as possible effort: 3 This can be/was resolved in minutes be requires/required deep engagement effort: 5 This may require/required hours of work platform: web/desktop This is related to web/desktop platforms For: deployment This will affect our deployed system For: integration This is for work involving integration with the backend/model API labels Sep 10, 2024
@Rethakgetse-Manaka Rethakgetse-Manaka added this to the Week 3 Sprint 4 milestone Sep 10, 2024
@Rethakgetse-Manaka Rethakgetse-Manaka self-assigned this Sep 10, 2024
Copy link

gitguardian bot commented Sep 10, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13718678 Triggered Generic High Entropy Secret 867bd95 occupi-backend/pkg/handlers/realtime_handlers.go View secret
13718678 Triggered Generic High Entropy Secret 153cba9 occupi-backend/pkg/handlers/realtime_handlers.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 11.53846% with 115 lines in your changes missing coverage. Please review.

Project coverage is 32.24%. Comparing base (c2b6896) to head (d78796a).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
frontend/occupi-web/src/CentrifugoService.ts 12.87% 88 Missing ⚠️
frontend/occupi-web/src/AuthService.ts 7.69% 24 Missing ⚠️
frontend/occupi-web/src/CapacityService.ts 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c2b6896) and HEAD (d78796a). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (c2b6896) HEAD (d78796a)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #357       +/-   ##
============================================
- Coverage    69.34%   32.24%   -37.11%     
============================================
  Files           54       33       -21     
  Lines         5690     2258     -3432     
  Branches        84        0       -84     
============================================
- Hits          3946      728     -3218     
+ Misses        1659     1530      -129     
+ Partials        85        0       -85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym
Copy link
Member

waveyboym commented Sep 12, 2024

@Rethakgetse-Manaka Rethakgetse-Manaka marked this pull request as ready for review September 12, 2024 12:37
@Rethakgetse-Manaka Rethakgetse-Manaka merged commit 1a20d43 into develop Sep 12, 2024
7 of 10 checks passed
@Rethakgetse-Manaka Rethakgetse-Manaka deleted the feature/backend/Self-Implemented-Counter- branch September 12, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 3 This can be/was resolved in minutes be requires/required deep engagement effort: 5 This may require/required hours of work For: api This is mainly for the api For: backend This is mainly for the backend code For: deployment This will affect our deployed system For: frontend This is mainly related to frontend UI code For: integration This is for work involving integration with the backend/model API platform: web/desktop This is related to web/desktop platforms priority: high This needs/needed to be addressed as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants