-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BGC included 1deg_jra55_iaf #11
Conversation
Great, thanks @hakaseh. I can give it a whirl but it looks like Once we are happy with it I'll
|
Sounds good, thanks Andrew.
I realised I should change some of the input files, so I will create a new input directory for these experiments and will reply to this thread when it is ready.
From: Andrew Kiss ***@***.***>
Date: Thursday, 6 May 2021 at 11:23 am
To: COSIMA/1deg_jra55_iaf ***@***.***>
Cc: Hakase Hayashida ***@***.***>, Mention ***@***.***>
Subject: Re: [COSIMA/1deg_jra55_iaf] BGC included 1deg_jra55_iaf (#11)
Great, thanks @hakaseh<https://github.com/hakaseh>.
I can give it a whirl but it looks like /g/data/v45/hh0162/projects/icebgc/prep_omip2/input_iamip2/co2_obs_iamip2_con.nc is a broken link - can you fix that please?
Once we are happy with it I'll
* move those extra inputs to /g/data/ik11/inputs/access-om2
* set up the diagnostics using diag_table_source.yaml
* make the same changes to 1deg_jra55_ryf
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#11 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMDA5P42M2HQSJSPBZ2NGGLTMHVQFANCNFSM4376U7ZQ>.
|
Hi @aekiss. I created a new input directory for BGC runs. It is ready for testing. |
Thanks @hakaseh. Your PR's config.yaml uses You'll have to do some thing similar for CICE - see here. When you've committed your changes to CICE and libaccessom2 you should re-run |
Also there are permissions problems so I can't run your executables:
|
not sure if I understood correctly, but i should update the executables specified in config.yaml, correct? i noticed in the past that executables in config.yaml get updated automatically for some directories but not in other directories. do you know how it determines which config.yaml to modify automatically upon successful ./install.sh? |
The automatic updating of exes in config.yaml is done by hashexe.sh but it's a bit buggy and doesn't always work, so you may need to do it by hand. |
i see. The default directories (e.g. 1deg_jra55_iaf) are defined in hashexe.sh, so anything else i added (e.g. 1deg_jra55_iaf_iamip2_his) was not automatically updated. ok, i will do manually. i think i now understand what you mean by updating the executables. i can confirm that my latest CICE commit is: commit 30ba0cc90a1c0ed552a267dca03f8e68e7cf312e (HEAD -> iamip2, hakaseh/iamip2)
I only had to update MOM to fix the errors raised during PR. I just did "chmod 744 /home/581/hh0162/scratch/access-om2-iamip2/bin/". could you access now? |
What cice executable name do you get when you run install.sh? I can't access |
Oh I see. sorry i do have uncommitted changes in CICE, but that is not for this release of OM2-BGC. I've been testing different options for CICE like brine tracers. I modified the permissions again, hopefully this time works? |
We want to keep track of exactly what source code is used in the executables, so you should commit all your changes before you run install.sh. Also, can you tell me where your source code is? It might be easier if I look at it myself. I can now get into |
I guess the unrelated change in CICE is minimal, so instead of creating a new branch, I updated the iamip2 branch for cice now: I have a question before doing ./install.sh and updating executables. When I do
where the difference/modification is:
Do I need to commit this as well?
I don't understand what these mean, but found this thread: https://stackoverflow.com/a/4874323 should I follow? |
regarding permission issue, my scratch is v45, but the group was set to v19. not sure how this happened, but i just did |
I did "./install.sh" and it still produces *-modified.exe for CICE, e.g.:
so i think that *-dirty commit needs to be sorted? |
Hmm, it looks like your submodule links are old, e.g. ParallelIO 7309b9b6 is older than 7e242f7 which is what we currently use: https://github.com/COSIMA/cice5 Maybe try this and see it updates ParallelIO to 7e242f7
It's less clear what's wrong with libacessom2 submodules, as the hashes match those in https://github.com/COSIMA/libaccessom2/tree/44e8821ee
and see what it does... @aidanheerdegen do you have any better suggestions? It would be good if I could see your code directory but I still have no access to |
I don't know if I have ever updated other modules/directories than src/mom and src/cice, so maybe that's why.. I'll try your method. I'm currently doing
Do you think it would be easier if you pull my |
Recursively changing the permissions has created a lot of modified files in your source directory as you've made everything executable. Not sure this is heading in the right direction ... |
I had this issue before and managed to avoid it for src/cice and src/mom by following this: |
OK I'll try compiling them myself. But first - your cice5 iamip2 branch has slipped behind the current master in cice5 - see so can you go to your cice5 source directory and do
and then push it to your iamip2 branch on github? |
thanks @aekiss that'd be great. I have followed the steps to update the iamip2 branch of cice5. |
hi @hakaseh - just to update: so far I've merged your changes with the latest model components (in a private branch which I will share later), compiled and run successfully in physics-only. (edited)
I noticed your Is there a reason for this? If not, can we switch them all to |
My BGC run is failing with
|
thanks @hakase, I've merged my branch so you can pull |
@aekiss |
thanks @hakaseh, I've merged that into main. Does this mean we can delete |
Yup, we can delete them. Not used in simulations.
Regards,
Hakase
…________________________________
From: Andrew Kiss ***@***.***>
Sent: Friday, October 15, 2021 3:34:20 PM
To: COSIMA/1deg_jra55_iaf ***@***.***>
Cc: Hakase Hayashida ***@***.***>; Mention ***@***.***>
Subject: Re: [COSIMA/1deg_jra55_iaf] BGC included 1deg_jra55_iaf (#11)
thanks @hakaseh<https://github.com/hakaseh>, I've merged that into main. Does this mean we can delete
/g/data/v45/hh0162/projects/icebgc/prep_omip2/input_om2-bgc/*deg*/ocean_grid_xyz.nc
?
ie access-om2 doesn't use them?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#11 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMDA5PYGC5MXIIBKWEDTNOLUG6VMZANCNFSM4376U7ZQ>.
|
@hakaseh I've just been looking through |
|
|
Are these values OK? It seems odd that nutrient and algae would have the same values.
|
|
|
these attributes are already absent from |
Ideally we'd make changes in https://github.com/COSIMA/input_om2-bgc and re-generate the files, so we can document the provenance of each file by a global attribute with a link to the specific |
Anyway, it's the weekend so let's discuss next week. |
many thanks @aekiss for these checks. I'm going through your posts and try to address them all below. I'm busy with the CLEX OE workshop tomorrow until Wednesday, and it's the long weekend in Tasmania from Thursday until Sunday, so I might not get to these again until next week.
The initial conditions for these BGC tracers are somewhat arbitrary, unless they are used for short-term forecasting (initial value problem). I set all of these to 0.01 mmol/m3, which is a very small value, for simplicity. This is a common approach in BGC models, given the lack of climatology in these fields, and we know that these values are for the most part minimal, except in the upper 100 m ( Applying the sea-surface chlorophyll values throughout the upper 100 m is a big assumption about the vertical structure of phytoplankton distribution. Another assumption is the empirical relationship between phytoplankton and zooplankton biomass. To me, these assumptions introduce additional sources of uncertainty in the model. Anyway, I don't think the solution will be sensitive to these choices at interannual to decadal timescales of our simulations. |
I don't think I understand what |
this is my laziness 😄 i will fix this eventually. |
just to clarify, i was referring to i just did a test run by increasing |
@aekiss I've just updated And I also reflected this in |
@aekiss I've created a new branch |
Thanks @hakaseh I've compiled executables here for test runs
|
good morning @aekiss. I have updated I don't seem to have edit access for https://github.com/COSIMA/access-om2/projects/5. i can view but cannot move an item to another column, etc. |
Thanks @hakase I have incorporated that into the branch I'm working on Not sure what the issue is with the project board. Might not be able to look at that for a few days. |
The new input files in |
@aekiss should I close this issue/PR since I'm working now on |
closing this issue as we now have |
Hello @aekiss @aidanheerdegen @AndyHoggANU @russfiedler and maybe others,
I was not sure if creating pull request was the way to go, but I would like to let you know that I have updated 1deg_jra55_iaf with BGC. This should work with the recently developed BGC implementaiton: mom-ocean/MOM5#338 and COSIMA/cice5#58
To exchange two BGC tracers between ice and ocean, i2o.nc, o2i.nc, namcouple, ocean/input.nml, and ice/input_ice.nml were updated. The BGC input files are currently stored in /g/data/v45/hh0162/projects/icebgc/prep_omip2/iamip2
The default setup will run the model with physics only. To run the model with BGC, do:
cat ocean/field_table_bgc >> ocean/field_table
cat ocean/diag_table_bgc >> ocean/diag_table
The default BGC setup will include both ocean and sea-ice BGC. To turn off the sea-ice BGC, set
skl_bgc = .false.
inice/cice_input.nml
.Therefore, running the BGC model requires additional steps, but I think this is better than creating and maintaining two separate directories for physics-only and bgc-included experiments.
Any thoughts? Could you do test runs and if they are successful and you are happy with the way the directory is setup, I'll prepare for 0.25 and 0.1-degree (as well as RYF).