Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect halo update for calving flux #68

Open
aekiss opened this issue Mar 31, 2023 · 2 comments · May be fixed by #69
Open

Incorrect halo update for calving flux #68

aekiss opened this issue Mar 31, 2023 · 2 comments · May be fixed by #69

Comments

@aekiss
Copy link
Contributor

aekiss commented Mar 31, 2023

There's a bug here:

cice5/drivers/auscom/cpl_interface.F90

Line 710 in edcfa6f

call ice_HaloUpdate(calv0, halo_info, field_loc_center, field_type_vector)

Calving flux is a scalar, so this should be

  call ice_HaloUpdate(calv0, halo_info, field_loc_center, field_type_scalar)
@aekiss
Copy link
Contributor Author

aekiss commented Mar 31, 2023

This hasn't affected any production runs to date, because we add the solid runoff into the liquid runoff and don't use the solid runoff: COSIMA/access-om2#155 (comment)

@aekiss
Copy link
Contributor Author

aekiss commented Mar 31, 2023

It also doesn't explain the tripole seam bug COSIMA/access-om2#86 as this halo bug was introduced years later in commit 3bbef26

aekiss added a commit that referenced this issue Mar 31, 2023
@aekiss
fix calving flux halo update bug - closes #68
beebba7
This was referenced Mar 31, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix calving flux halo update bug COSIMA/cice5
1 participant
@aekiss