Fix incorrect "failed" status in DB update #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck permissions sets the build as unstable before the database update PBS job isfinished, then the 'Update database' step will check if the job time-out and mark the build as failed even if the job ran without any error.
…, also send the failed permissions email to myself and Andrew.
aekiss
approved these changes
Nov 22, 2022
| to: '${FILE, path="blame_list"}', | ||
| cc: 'micael.oliveira@anu.edu.au, andrew.kiss@anu.edu.au', | ||
| replyTo: 'micael.oliveira@anu.edu.au, andrew.kiss@anu.edu.au', | ||
| body: 'Dear user,\n\n While updating the COSIMA Cookbook database, we found that several files that you own have incorrect permissions or they belong to the wrong group, which prevented us from adding them to the database. You can find the full list of files below (Note: It may be that you own only a subset of these files). We would be grateful if you could fix this issue by making sure that the group has read permissions for all files and directories, that the group has execute permissions for all directories, and that all files and directories belong to one of the following groups: ik11, hh5, or cj50.\nNote that this email is generated automatically. If you believe you have received this email by mistake, please contact Micael Oliveira (micael.oliveira@anu.edu.au) or Andrew Kiss (andrew.kiss@anu.edu.au).\n\nThe following files and/or directories have incorrect permissions:\n\n${FILE, path="incorrect_permissions"}', |
There was a problem hiding this comment.
Good catch. This actually needs to go in the other the PR (#32), not this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some refactoring of the Jenkins code.