Adds Avtp_<Format>_IsValid() functions for all AVTP/ACF frame formats #52 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warlock20
changed the title
|
Many thanks. Looks good at first glance. I'm going to merge this on Monday or Tuesday next week. |
|
@warlock20 Our CI pipeline fails due to the use of bool. So far we have been using uint8_t for bit flags to remain platform agnostic without additional hassles. |
nayakned
reviewed
Feb 3, 2025
…o uint8_t. Adds a definition for TRUE and FALSE in Defines.h
…converts the length to octets
|
Code base updated as per the feedback @nayakned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52